Problem/Motivation

The unofficial API for associating temporary data to entity objects is being considered for deprecation in #2896474: Provide an API to temporarily associate data with an entity. Workspaces uses it to keep track of entities that were created as published inside a workspace, so it can unpublish the default (Live) revision.

Steps to reproduce

Look at \Drupal\workspaces\Hook\EntityOperations::entityPresave().

Proposed resolution

Remove the usage of temporary entity data.

Remaining tasks

Review.

User interface changes

Nope.

Introduced terminology

N/A

API changes

Nope.

Data model changes

Nope.

Release notes snippet

N/A

Issue fork drupal-3498115

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

amateescu created an issue. See original summary.

amateescu opened merge request !10842

amateescu’s picture

amateescu commented
Status: Active » Needs review

Opened a MR to fix this. It doesn't need any new test coverage, this behavior is already tested in a lot of places.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Seems like a good refactor to me.

  • catch committed 86b2f9e2 on 11.x 
    Issue #3498115 by amateescu: Fix usage of temporary entity data in...

catch closed merge request !10842

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

I don't think we need to backport this anywhere, but re-open if I've missed something.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.