Problem/Motivation
An error message displayed when the mail_login module is used together with the TFA module.
TypeError:
Drupal\mail_login\AuthDecorator::__construct(): Argument #1
($user_auth) must be of type Drupal\user\UserAuthenticationInterface,
Drupal\tfa\TfaUserAuth given
Steps to reproduce
Use latest version of mail_login module (4.0.3)
Use latest version of TFA (2.0.0-alpha4)
Enable both modules using Drupal core 10.3.10.
Proposed resolution
The maintainer of TFA suggested to address the issue in mail_login, therefore I created a fix.
After applying the patch no error is triggered any more.
Remaining tasks
These checks won't be necessary any more when the old UserAuthInterface will be retired in Drupal 12, until that we need some changes to make them work together.
Old interface: https://git.drupalcode.org/project/drupal/-/blob/10.3.x/core/modules/use...
New interface: https://git.drupalcode.org/project/drupal/-/blob/10.3.x/core/modules/use...
| Comment | File | Size | Author |
|---|
Issue fork mail_login-3497643
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 4.0.x
changes, plain diff MR !20
- 3497643-backward-compatibility-fix
compare
Comments
Comment #4
imre.horjanI've created the MR
Comment #5
imre.horjanThe patch has also been hidden
Comment #6
imre.horjanComment #7
tomsaw commentedMR !20 worked for me.
drupal/mail_login with drupal/tfa works in my D10 again.
Comment #8
mqannehComment #10
mqannehComment #11
mqanneh