Problem/Motivation

While running tests of the next major PHP version for OpenID Connect, we started seeing the following deprecation messages coming from ExternalAuth:

Deprecated: Drupal\externalauth\Authmap::delete(): Implicitly marking parameter $provider as nullable is deprecated, the explicit nullable type must be used instead in /builds/project/openid_connect/web/modules/contrib/externalauth/src/Authmap.php on line 123

Deprecated: Drupal\externalauth\AuthmapInterface::delete(): Implicitly marking parameter $provider as nullable is deprecated, the explicit nullable type must be used instead in /builds/project/openid_connect/web/modules/contrib/externalauth/src/AuthmapInterface.php on line 90

Those messages are displaying here: https://git.drupalcode.org/project/openid_connect/-/jobs/3848290#L188

Proposed resolution

Change the method definition from:

public function delete(int $uid, string $provider = NULL) {

to

public function delete(int $uid, ?string $provider = NULL) {
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

pfrilling created an issue. See original summary.

deepali sardana’s picture

Assigned: Unassigned »

deepali sardana’s picture

Assigned: » Unassigned
Status: Active » Needs review
pfrilling’s picture

Status: Needs review » Needs work

Left a few comments in the MR that need to should be addressed.

idebr made their first commit to this issue’s fork.

idebr’s picture

Status: Needs work » Needs review

The remaining deprecations are now fixed in the merge request

pfrilling’s picture

Status: Needs review » Reviewed & tested by the community

Looks good. I believe they were all addressed.

svendecabooter’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for the improvements. Merged now

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.