Needs work
Project:
Drupal core
Version:
main
Component:
install system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
30 Dec 2024 at 12:39 UTC
Updated:
15 Jan 2025 at 15:41 UTC
Jump to comment: Most recent
Comments
Comment #3
alexpottLet's see what breaks. This fixes #3496091: Improve the way we enable Trash support by default for nodes as expected.
Comment #4
alexpottNothing breaks... interesting. This looks like a sensible change to me but not sure. Here be dragons.
Comment #5
alexpottI think there is no reason when hook_modules_installed should come after the router rebuild. Note that if anything does use a route in hook_modules_installed the router will be rebuilt if necessary as this change would mean code would be using the lazy_builder route provider.
Comment #6
nicxvan commentedI think this makes sense, I'm not sure how we'd test this to be honest. I'd expect to not see the effects until contrib test runs go against it since core didn't trigger any failures.
Comment #7
smustgrave commentedNot sure if trash is unique? But could it not be mimics from a test module?