Problem

The casing seems weird and off-standard. Classes/Traits should start upper-case. API is spelled "Api" in camel case.

Proposed resolution

Fix it quickly before next release.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

fago created an issue. See original summary.

kul.pratap made their first commit to this issue’s fork.

kul.pratap’s picture

Assigned: Unassigned » kul.pratap

useernamee made their first commit to this issue’s fork.

useernamee’s picture

Assigned: kul.pratap » fago
Status: Active » Needs review

I added a MR, since I was already working on ld.

roderik’s picture

Assigned: fago » Unassigned
Status: Needs review » Reviewed & tested by the community

[ catching simple reviews from fago ]

TIL trait names are case insensitive (unlike class names). So even if someone else would already be using this trait, things will not break.

(Tested by only renaming the trait, and leaving the 'use' statements unchanged: things still work.)

  • fago committed e5422062 on 1.x authored by useernamee
    Issue #3496502 by useernamee, roderik: apiResponseTrait should be...
fago’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.