Problem/Motivation
The version: VERSION lines in libraries.yml are creating a version query string using the Drupal Core version number for the asset files, making these files cached in the browser dependent on the Core version.
Steps to reproduce
This can produce various problems after an update, as the old versions of assets might be loaded for users who have those cached. The only way to currently fix those to clear the browser cache.
Proposed resolution
Remove the version: VERSION lines from libraries.yml. By doing this, Drupal will use an automatically generated query string added to filenames. From the code documentation:
The string changes on every update or full cache flush, forcing browsers to load a new copy of the files as the URL changed.
See: web/core/lib/Drupal/Core/Asset/JsCollectionRenderer.php:62
The other option is to explicitly set the module's version on these lines and keep track of it when the version number changes/the asset is updated.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | before-after.png | 16.75 KB | jannakha |
Issue fork editor_advanced_link-3495882
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
dieterholvoet commentedComment #4
jannakha commentedbefore/after:

patch good to go!
thanks for your contribution.
Comment #5
hosterholzRTBC+1
Comment #9
duaelfrThanks!
This is fixed and will be included in the upcoming 2.2.10 and 2.3.2 versions.