Overview

XB CI currently runs against 10.4.x and 11.1.x. Stable versions of these have been released so we can remove some of our CI template overrides.

Proposed resolution

Run tests against Drupal 11.1, 10.4, and additionally give us warning of future issues by running against 11.x (deferred until #3497866: CI: also test against next minor: 11.2.x aka Drupal 11.x HEAD)

User interface changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

longwave created an issue. See original summary.

longwave’s picture

Issue summary: View changes
longwave’s picture

Status: Active » Needs work

This is showing some interesting fails in 11.x that need further investigation.

longwave’s picture

At least some of the fails appear to be related to #3416522: Add the ability to install multiple modules and only do a single container rebuild to ModuleInstaller. Experience Builder creates config entities in hook_rebuild(), this means that we can no longer install XB and other config that depends on XB's generated config entities at the same time.

Even setting container_rebuild_required: true doesn't help because config validity is checked for the entire set of modules, not per group:

    // Check the validity of the default configuration. This will throw
    // exceptions if the configuration is not valid.
    $config_installer->checkConfigurationToInstall('module', $module_list);

    // Some modules require a container rebuild before and after install.
    // Group modules such that as many are installed together as possible until
    // one needs a container rebuild.
    $module_groups = [];
    $index = 0;
    foreach ($module_list as $module) {
      // Ensure the container is rebuilt both before and after a module that
      // requires a container rebuild is installed.
      $container_rebuild_required = !empty($module_data[$module]->info['container_rebuild_required']);
longwave’s picture

Opened #3497173: Modules that create config cannot be installed alongside modules that depend on that config for #5.

Unsure if we actually want to hard fail on errors in 11.x or let them slide for now, as long as we fix them before 11.2 is out we are OK, and chasing HEAD is difficult, especially if core makes a change and MR tests start failing for reasons unrelated to the MR itself. Maybe we should only fail "next minor" on branch tests and not MRs?

longwave’s picture

The fails in ComponentTreeItemTest are also solved by adding container_rebuild_required: true to xb_test_config_node_article.info.yml.

longwave’s picture

Assigned: longwave » Unassigned
Status: Needs work » Needs review

Reverted the fail-on-next-minor change, let's fix that over in #3497866: CI: also test against next minor: 11.2.x aka Drupal 11.x HEAD

wim leers’s picture

Title: Update CI templates for Drupal 11.1.0 » CI: update template for Drupal 11.1.0
Status: Needs review » Needs work
Related issues: +#3497173: Modules that create config cannot be installed alongside modules that depend on that config

+1 — but then the MR needs a small update :)

longwave’s picture

Status: Needs work » Needs review
longwave’s picture

Issue summary: View changes
longwave’s picture

Issue summary: View changes
wim leers’s picture

Status: Needs review » Reviewed & tested by the community

wim leers’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.