Problem/Motivation

It is currently not possible to override client_ip_address and client_user_agent parts of the user data as there is an incorrectly named variable inside of MetaClient::sendRequest().

At the moment, you can pass in client_ip_address and client_user_agent but due to the incorrectly named variable, the values won't be found and it will fall back to setting the two values at this point in time instead.

Steps to reproduce

Call the ::sendRequest() method from the MetaClient and pass in client_ip_address and client_user_agent as part of the $userData parameter. Those values won't be used and the values will be generated by the fallback code.

Proposed resolution

Fix the incorrectly named variable.

Remaining tasks

Code the fix.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Issue fork meta_conversions_api-3495027

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

rossb89 created an issue. See original summary.

rossb89 opened merge request !4

rossb89’s picture

rossb89 commented
Status: Active » Needs review

MR added, marked as needs review.

rossb89’s picture

rossb89 commented
Assigned: rossb89 » Unassigned

  • rob230 committed eec01d5e on 1.x authored by rossb89 
    #3495027 - Fix incorrectly named variable used when checking...
rob230’s picture

rob230 commented
Status: Needs review » Fixed

Thank you.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.