Problem/Motivation

FILE:

web/modules/custom/views_taxonomy_term_name_into_id/tests/src/Functional/Argumen
tValidatorTest.php

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Fix now        28   Usage of deprecated trait
                    Drupal\Tests\field\Traits\EntityReferenceTestTrait in class
                    Drupal\Tests\views_taxonomy_term_name_into_id\Functional\Arg
                    umentValidatorTest. Deprecated in drupal:10.2.0 and is
                    removed from drupal:11.0.0. Use
                    Drupal\Tests\field\Traits\EntityReferenceFieldCreationTrait
                    instead.
--------------------------------------------------------------------------------

FILE:
web/modules/custom/views_taxonomy_term_name_into_id/tests/modules/views_taxonomy
_term_name_into_id_test/test_views/views.view.test_argument_taxonomy_name_into_i
d.yml

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Check manually 177  Support from all Views contextual filter settings for the
                    default_argument_skip_url setting is removed from
                    drupal:11.0.0. No replacement is provided. See
                    https://www.drupal.org/node/3382316.
--------------------------------------------------------------------------------

FILE:
web/modules/custom/views_taxonomy_term_name_into_id/views_taxonomy_term_name_int
o_id.info.yml

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Check manually 4    Value of core_version_requirement: ^8 || ^9 || ^10 is not
                    compatible with the next major version of Drupal core. See
                    https://drupal.org/node/3070687.
--------------------------------------------------------------------------------
CommentFileSizeAuthor
#14 views_taxonomy_term_name_into_id-3494573-D11_compatibility.patch4.93 KBalbeorte
#9 d11support-3494573-9.patch3.22 KBjonasanne
#6 Screenshot 2024-12-27 at 5.30.16 PM.png66.38 KBrahul17

Issue fork views_taxonomy_term_name_into_id-3494573

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kevinfunk created an issue. See original summary.

kevinfunk opened merge request !5

kevinfunk’s picture

kevinfunk
he/him
commented
Status: Active » Needs review

I also addressed Remove 8.7.x fallback code for TaxonomyTestTrait since the support for D8 was dropped. Please let me know if you want me to add it back and created a new MR for Remove 8.7.x fallback code for TaxonomyTestTrait.

patelh84 made their first commit to this issue’s fork.

patelh84 opened merge request !6

rahul17’s picture

rahul17 commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot 2024-12-27 at 5.30.16 PM.png66.38 KB

I have verified MR !6 against Drupal 10 and Drupal 11, functionality is working as expected. No issues found in upgrade status as well.
Moving this to RTBC.

bserem’s picture

bserem commented

Can we get this merged please?

jonasanne’s picture

jonasanne commented

+1 for merge please.

jonasanne’s picture

jonasanne commented
StatusFileSize
new d11support-3494573-9.patch3.22 KB

added mr as patch

dww’s picture

dww
we/he/they
commented
Status: Reviewed & tested by the community » Postponed

I won't merge this until #3482593: Enable GitLab CI and cleanup build pipelines is done and we have passing green pipelines on all relevant versions.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Issue summary: View changes
Status: Postponed » Needs work
Related issues: +#3482593: Enable GitLab CI and cleanup build pipelines

Most of the changes are in #3482593: Enable GitLab CI and cleanup build pipelines.

jkamizato made their first commit to this issue’s fork.

albeorte’s picture

albeorte commented
Status: Needs work » Reviewed & tested by the community

Hi @dww,

Regarding the changes in the Merge request !6, have been tested and work correctly, please merge them and release a Drupal 11 compatible version.

In the issue you mentioned that is relevant to merge before this one, the tests are passing as expected:

The module is ready to release the Drupal 11 compatible version.

Thanks in advance

albeorte’s picture

albeorte commented
StatusFileSize
new views_taxonomy_term_name_into_id-3494573-D11_compatibility.patch4.93 KB

Added MR as patch

dadderley’s picture

dadderley commented

It would be nice to have a Drupal 11 version of the module.

dww’s picture

dww
we/he/they
commented

Yup, I’ll hopefully get something out next week. Been working at a music camp and offline for a while, but starting to catch up on virtual work now…

dadderley’s picture

dadderley commented

Thanks

vinodhini.e’s picture

vinodhini.e commented

Hi, I tested this module on Drupal 11.2.x and encountered a compatibility issue. After applying Merge Request #6, it is working correctly and is now compatible with Drupal 11.
Thanks!

maheshv’s picture

maheshv commented

Can we get the D11 version released, please?

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented

+1 - this module is blocking us from upgrading a site to D11.

maheshv’s picture

maheshv commented

Our Project is blocked due to this module d11 release, can you please release the d11 version ASAP.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Reviewed & tested by the community » Closed (outdated)

Thank you for your contributions. 🎂
Drupal 7 is no longer supported. 🚀
Marking as outdated.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

shelane’s picture

shelane
Primary language English
commented
Status: Closed (outdated) » Reviewed & tested by the community

Why was this closed? This issue has nothing to do with Drupal 7. Users are still waiting for the Drupal 11 compatible version, which is this issue.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented

Thanks @shelane.
Task seems like a victim of D7 tasks.

dadderley’s picture

dadderley commented

Is there a Drupal 11 release in the works?

dww’s picture

dww
we/he/they
commented

I have no idea what @vladimiraus is talking about with "D7 tasks". This module has never supported D7 (since D7 views provided this functionality itself). Totally unhelpful and confusing comments. Please don't close issues where you don't know what you're talking about. 😅

Anyway, yes, I absolutely plan to fix this (and #3482593: Enable GitLab CI and cleanup build pipelines) and get another release out that supports D11. I'm finally getting through a giant backlog of other responsibilities, and hope to move this forward next week. 🤞

dadderley’s picture

dadderley commented

Thanks dww.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented

Just whistle if you need a help maintaining the module.
Happy to help.

mihaic’s picture

mihaic commented

A new release will be great thanks !

dww closed merge request !6

dww closed merge request !5

dww’s picture

dww
we/he/they
commented
Assigned: Unassigned » dww
Status: Reviewed & tested by the community » Needs work

I don't want to drop support for old versions like this. I also don't want/need a composer.json here. I'm going to start a new branch and a new MR that's the way I want to handle this.

dww opened merge request !7

dww’s picture

dww
we/he/they
commented
Assigned: dww » Unassigned
Status: Needs work » Needs review

MR 7 is the way forward. Let's see what the bot thinks. 😅

  • dww committed 96d21bfc on 8.x-1.x 
    task: #3494573 Add Drupal 11 compatibility

By: @dww

dww closed merge request !7

dww’s picture

dww
we/he/they
commented
Status: Needs review » Fixed
Issue tags: -Drupal 11 compatibility

Merged to 8.x-1.x branch. I'll tag a stable 8.x-1.0 release next.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

dww’s picture

dww
we/he/they
commented
Version: 8.x-1.x-dev » 8.x-1.0

https://www.drupal.org/project/views_taxonomy_term_name_into_id/releases... is now out.

dadderley’s picture

dadderley commented

I have installed this on a Drupal 10.5.6 site and then did the upgrade to Drupal 11.2.8.
It seems to be working fine, thankyou.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.