Move file_get_content_headers() to a method on the file entity

@Kim, Sure I will update my changes for the MR in sometime and provide an update

@Kim, I have updated the MR with the changes and created a change record for this change https://www.drupal.org/node/3494172. All tests pass.

If you added the needs tests tag to test the deprecation we don't need tests for that.

https://www.drupal.org/about/core/policies/core-change-policies/how-to-d...

If it's for something else let me know.

I left this on the MR too just because I sometimes miss the comments at the bottom of the overview page.

+1, I agree with @kimpepper.
Renaming the function name to getDownloadHeaders() sounds better and justifies the functionality implemented.

Moving this to needs work.

@Kim, I have changed the method name to getDownloadHeaders().
Moving this to review, please check.

Small comment on MR
CR needs to be updated for 11.2 also

May count as an API change? If yes that section should be updated

Thanks

@kim,@smustgrave: The merge conflicts from the 11.x rebase on this MR has been resolved and I fixed few CI issues related to the 11.x changes in this MR. I had updated the CR related to this change as well. Please check

Need rebase.

But typehint can be added to the hook so we don’t need to add to the baseline

@smustgrave, I have made the necessary changes, please check.

Reviewed.

One issue with the deprecation, if you can apply my suggestion I see no other issues after reviewing this, I can RTBC after this.

Done! Nice catch @nicxvan! Thx ;)

Looks great now thanks!

Committed/pushed to 11.x, thanks!