This is a tracking issue for the bare minimum that needs to happen before we can ship Group 4.0.0. Please feel free to comment but refrain from updating the issue summary.

I will create dedicated issues as we get closer to working on this.

Postponed until 4.1.x

Comments

kristiaanvandeneynde created an issue. See original summary.

kristiaanvandeneynde’s picture

Version: 3.3.x-dev » 4.0.x-dev
kristiaanvandeneynde’s picture

Issue summary: View changes
kristiaanvandeneynde’s picture

Issue summary: View changes
kristiaanvandeneynde’s picture

Issue summary: View changes
kristiaanvandeneynde’s picture

Issue summary: View changes
gorkagr’s picture

Hi!
Thanks a lot for the roadmap :)

Maybe Stop saving an entity when it gets added to a group is linked to #3057483 (core) and/or #2872697 (group) / #3478088 (group)

Best

kristiaanvandeneynde’s picture

Uh yeah, there's an issue for that one already I just had to find it :) Thanks

kristiaanvandeneynde’s picture

Issue summary: View changes
heddn’s picture

I thought I saw that

Disallow automatic membership outside of form approach

already made it in. Can we confirm?

kristiaanvandeneynde’s picture

From Group:

  /**
   * {@inheritdoc}
   */
  public function postSave(EntityStorageInterface $storage, $update = TRUE) {
    parent::postSave($storage, $update);

    // If a new group is created and the group type is configured to grant group
    // creators a membership by default, add the creator as a member unless it
    // is being created using the wizard.
    // @todo Deprecate in 8.x-2.x in favor of a form-only approach. API-created
    //   groups should not get this functionality because it may create
    //   incomplete group memberships.
    $group_type = $this->getGroupType();
    if ($update === FALSE && $group_type->creatorGetsMembership() && !$group_type->creatorMustCompleteMembership()) {
      $values = ['group_roles' => $group_type->getCreatorRoleIds()];
      $this->addMember($this->getOwner(), $values);
    }
  }

Edit: We did fix a bug where duplicate memberships were being created, though. That was related to the above code.

gorkagr’s picture

I have opened https://www.drupal.org/project/group/issues/3494986 to check the DI in controllers there (and maybe the __construct methods) :)

Best

kristiaanvandeneynde’s picture

Issue summary: View changes

Added to the list, along with "Drop constructor documentation and use property promotion where possible"

kristiaanvandeneynde’s picture

Issue summary: View changes

Added a kickass idea for a new editorial workflow

kristiaanvandeneynde’s picture

Issue summary: View changes
kristiaanvandeneynde’s picture

Issue summary: View changes
kristiaanvandeneynde’s picture

Issue summary: View changes
moshe weitzman’s picture

Great to see this Roadmap.

Some nice to have (if applicable):

  1. Use SDC
  2. Integrate a top level menu item into Navigation module (maybe this is done automatically)
kristiaanvandeneynde’s picture

Issue summary: View changes

Could look into SDC, is there an example of applying it to entities? I don't think I have anything else in my hook_theme. The permissions UI uses an inline template for some small things.

The top level menu thing we definitely need to look into for D11.

kristiaanvandeneynde’s picture

Issue summary: View changes
kristiaanvandeneynde’s picture

List is getting smaller :) Next one to tackle is probably the easy navigation entry and then "Disallow automatic membership outside of form approach". The brand-new creation UI I'm on the fence whether I want to add this now or at a later time. Still deciding...

kristiaanvandeneynde’s picture

Issue summary: View changes
kristiaanvandeneynde’s picture

Issue summary: View changes

Thinking of lifting the new editor flow where we use contexts into a minor release. Already getting rid of the wizard in the issue about not allowing automatic memberships outside of the form approach so that's one step in the right direction. Then 4.1 could contain more context provider support.

kristiaanvandeneynde’s picture

Issue summary: View changes
dalemoore’s picture

Do you have plans to support Group and Drupal Canvas? Since Drupal Canvas can now control the entire site layout/template, being able to to integrate Drupal Canvas and Group would be great. For instance right now I have some custom block plugins that only load in the header and footer if the page is part of a group (microsite) as well as menus using Group Content Menu where the main menu and secondary (footer) menu only load in groups to replace the global menus. I don't know if all this works OOTB with Drupal Canvas and Group yet (plan to test soon as I do plan to convert our entire site over to using Canvas). Just something to think about! (Obviously I'm using SDCs for the site already)

kristiaanvandeneynde’s picture

I guess most of it will "just work"? And if not, patches are always welcome :) But it's not really high on my priority list right now.

kristiaanvandeneynde’s picture

kristiaanvandeneynde’s picture

Issue summary: View changes
kristiaanvandeneynde’s picture

Issue summary: View changes
carolpettirossi’s picture

@dalemore if you need Drupal Canvas pages integrated with Group I started the module here: https://www.drupal.org/project/group_canvas