Problem/Motivation

x@x:~/public_html/www.x.de$ drush en posthog_js
 [warning] Drush command terminated abnormally.
x@x:~/public_html/www.x.de$ drush cr
 [warning] Drush command terminated abnormally.

No entries in log, yet unclear what goes wrong!

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork posthog-3493339

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Found it:

Type of Drupal\posthog_js\Form\SettingsForm::$typedConfigManager must not be defined (as in class Drupal\Core\Form\ConfigFormBase) in /web/modules/contrib/posthog/modules/posthog_js/src/Form/SettingsForm.php on line 20

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » grevil

@grevil: Important, this is a risky and ugly thing... See #3406389: Fatal error: Type of Drupal\geocoder\Form\SettingsForm::$typedConfigManager must not be defined (as in class Drupal\Core\Form\ConfigFormBase) for details.

anybody opened merge request !2

  • anybody committed 4007e00f on 1.x 
    Issue #3493339 by anybody: "[warning] Drush command terminated...
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: grevil » Unassigned
Status: Active » Fixed
grevil’s picture

grevil commented
Status: Fixed » Active

This fix caused a regression for Drupal 11. We should make separate releases for D10 and D11:

PHP Fatal error: Type of Drupal\posthog_js\Form\SettingsForm::$typedConfigManager must be Drupal\Core\Config\TypedConfigManagerInterface (as in class Drupal\Core\Form\ConfigFormBase) in /var/www/html/web/modules/custom/posthog/modules/posthog_js/src/Form/SettingsForm.php on line 0

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@grevil No I think there's a pattern to solve this. Look into similar widely used modules, they surely had the same issue.
Separate releases are no good solution for such a specific issue.

grevil’s picture

grevil commented
Status: Active » Fixed

I think I found something. The fix will be introduced through #3480882: Finish PHP SDK base integration.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Thanks, please retry afterwards!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.