The Block module uses vertical tabs to present visibility settings on the block form.
For example, on /admin/structure/block/manage/olivero_site_branding
This has been broken since #3467860: Ensure consistent ordering when calculating library asset order changed when the vertical-tabs library was loaded. CKEditor 5's library definitions were updated accordingly, but not Block.
Visit the block form and scroll down to the Visibility section, note that each vertical tab has the string "Not Required" appended.
Expected:
Actual:
Following the CR instructions, add the library as an explicit dependency.
Write tests
| Comment | File | Size | Author |
|---|---|---|---|
| Configure block Expected.png | 1.07 MB | tim.plunkett | |
| Configure block Actual.png | 1.13 MB | tim.plunkett |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !10522
Comments
Comment #4
tim.plunkettCrediting @lauriii who found the bug. NW for tests
Comment #5
catchThis is visually a very bad regression, so I think we should commit the quick fix and add some general test coverage for block visibility vertical tabs in #3493914: Write functional javascript test for block visibility vertical tabs - presumably we have none otherwise this would have been caught.
Comment #6
catchMoving to RTBC, let's add more comprehensive coverage in the other issue.
Comment #7
catchComment #12
quietone commentedI agree with catch that due to the severity of this visual regression that the fix should be in the release without a test. I may also use this as an opportunity to write my first FunctionalJS test, who knows!
Committed to 11.x and cherry-picked to 11.1.x 10.5.x 10.4.x
Thanks!