Problem/Motivation

 > cspell -------------------------------------- ◯ ^8.16.0 ------ ◉ ^8.16.1 ------

Note; This bump, although small, has been given its own issue, because it actually requires changes outside the package.json and/or yarn.lock-file.

@longwave confirmed it's okay (in this specific case) to bundle all JavaScript dependencies that don't have the above changes in a single issue.
This is very welcome, because it means a lot can be done in one issue and basically every extra issue about JavaScript dependencies ends up in reroll-limbo if any of the other JavaScript dependencies gets committed.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3493141

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

spokje created an issue. See original summary.

spokje opened merge request !10520

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review
spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
quietone’s picture

quietone commented

@spokje, did you rebuild the dictionary? Both kernighan and richie were removed the dictionary earlier this year in #3449356: Rebuild dictionary.txt. I applied this diff, reinstalled, and rebuilt the dictionary and both those names were removed.

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: Unassigned » spokje
Status: Needs review » Needs work

@quietone, Crap I fell into my old nemisis' trap yet again: Running a dictionary rebuild on a non-clean core checkout.

Thanks for noticing, I'll fix that right away.

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned
Status: Needs work » Needs review

Reran $ yarn spellcheck:make-dict on a clean core checkout.

Thanks again @quietone!

quietone’s picture

quietone commented
Status: Needs review » Reviewed & tested by the community

@spokje, Thanks!

  • longwave committed a24ffe4f on 11.1.x 
    Issue #3493141 by spokje, quietone: Bump cspell to 8.16.1

  • longwave committed 35d0e5e0 on 11.x 
    Issue #3493141 by spokje, quietone: Bump cspell to 8.16.1
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: 11.x-dev » 10.5.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed and pushed to 11.x and 11.1.x, thanks!

Marking for backport to 10.4.x/10.5.x.

spokje opened merge request !10524

spokje changed the visibility of the branch 3493141-bump-cspell-to to hidden.

spokje changed the visibility of the branch 11.x to hidden.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Patch (to be ported) » Needs review

  • longwave committed 4e984283 on 10.5.x 
    Issue #3493141 by spokje, quietone: Bump cspell to 8.16.1
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: 10.5.x-dev » 10.4.x-dev
Status: Needs review » Patch (to be ported)

Committed to 10.5.x, doesn't cherry-pick cleanly to 10.4.x due to conflicts in yarn.lock - although there shouldn't be any, so not sure what's happened there.

quietone opened merge request !10533

quietone’s picture

quietone commented

The hash for dict-golang didn't match. 

$ git apply -v 10524.diff
Checking patch core/misc/cspell/dictionary.txt...
Checking patch core/package.json...
Checking patch core/yarn.lock...
error: while searching for:
  resolved "https://registry.yarnpkg.com/@cspell/dict-git/-/dict-git-3.0.3.tgz#3a3805ab9902bffc9255ec48f648145b957eb30b"
  integrity sha512-LSxB+psZ0qoj83GkyjeEH/ZViyVsGEF/A6BAo8Nqc0w0HjD2qX/QR4sfA6JHUgQ3Yi/ccxdK7xNIo67L2ScW5A==

"@cspell/dict-golang@^6.0.16":
  version "6.0.17"
  resolved "https://registry.yarnpkg.com/@cspell/dict-golang/-/dict-golang-6.0.17.tgz#8f3c11189b869db7216cb4496514b9882d1e30a5"
  integrity sha512-uDDLEJ/cHdLiqPw4+5BnmIo2i/TSR+uDvYd6JlBjTmjBKpOCyvUgYRztH7nv5e7virsN5WDiUWah4/ATQGz4Pw==

10.4.0-rc1 was tagged with dict-golang at 6.0.17 but then when the branch went 'back to dev' it was 6.0.16. What happened there?

  • longwave committed 1944dc50 on 10.4.x 
    Issue #3493141 by spokje, quietone: Bump cspell to 8.16.1
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Patch (to be ported) » Fixed

Committed 1944dc5 and pushed to 10.4.x. Thanks!

longwave closed merge request !10533

longwave closed merge request !10524

longwave closed merge request !10520

tr’s picture

tr commented

Maybe not directly related, but "varchar" is now being flagged as spelled wrong in GitLabCI tests with cspell 8.16.1

My last test where it it ran green was on 14 Dec using cspell 8.13.0
My first test where it failed was on 18 Dec using cspell 8.16.1
There were no commits to the project between these two runs, but of course core 11.1 was released so GitLabCI now automatically uses that, which also changed some of the dependencies I assume.

The line of code (in hook_schema() in an install file) hasn't changed in almost 9 years. Core uses 'varchar' more than 1000 times.

Why is it being flagged in contrib testing? Is this due to a template change? I don't see varchar in the dictionary before or after this change.

Failing cspell job:
https://git.drupalcode.org/project/honeypot/-/jobs/3750200

Passing cspell job:
https://git.drupalcode.org/project/honeypot/-/jobs/3669640

I have other projects that now also have this same cspell error.

spokje’s picture

spokje
Primary language Dutch
commented

Hmmm,

If I search core for "varchar" I get ~1200 results, so I would expect those to fail in the core GitLab CI, which they don't.

So that makes me think it's a GitLab (config of cspell-run) problem, and not a specific cspell version problem?

quietone’s picture

quietone commented

When the dictionary was rebuilt just before the commit to 11.x, the word 'varchar' was removed from the dictionary. Curiously, yarn cspell trace varchar does not show the word is in any of the dictionaries Drupal uses.

tr’s picture

tr commented

OK, so varchar was removed from the dictionary as part of #3460114: Update JavaScript dependencies for Drupal 11.0-rc, back in July in 11.0-rc. Not sure why it's only now causing a problem in 11.1 ?

I guess that was unintentional, because there is no mention of this in the issue comments? Regardless, the changes to the dictionary made in that issue ought to get a second look because varchar may not be the only thing unintentionally removed ...

So where is the appropriate place to open an issue for this?

tr’s picture

tr commented

If this isn't something that can or should be handled here ...

So where is the appropriate place to open an issue for this?

elc’s picture

elc commented
Related issues: +#3498323: CSpell: *.install,*.module etc should be treated as PHP so 'varchar' is not treated as a spelling mistake

Created an issue: #3498323: CSpell: *.install,*.module etc should be treated as PHP so 'varchar' is not treated as a spelling mistake

Task/Other issue on Drupal Core seems to be the place to discuss and do these things.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.