Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3492705

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch opened merge request !10496

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review
mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Status: Needs review » Needs work

I think this will increase the index twice if we install two $container_rebuild_required modules in a row. This would probably work, but we would call module install with an empty array. Or if the first (or only) module requires a container rebuild.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community
Related issues: +#3492722: Update XB to require Drupal 11.2

Experience Builder got a new test fail on 11.x HEAD, this issue fixes it. See #3492722: Update XB to require Drupal 11.2

The change here makes sense to me, so marking RTBC.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Status: Reviewed & tested by the community » Needs work

Just need to tweak the comment above those sections in the installers referencing modules that need container rebuilds "immediately after install". We also will need to update the CR here at some point after this is merged.

nicxvan made their first commit to this issue’s fork.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Status: Needs work » Needs review
mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Status: Needs review » Reviewed & tested by the community

Looks good. I concur with @longwave on the fix, and I'm happy with the comments.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Crediting everyone as discussions and the MR brought this fix about quickly.

  • alexpott committed 16967de8 on 11.x 
    Issue #3492705 by catch, nicxvan, mikelutz, longwave: Install modules...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 16967de and pushed to 11.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

nicxvan’s picture

nicxvan commented

Updating credit