Problem/Motivation

PHP 8.4 has deprecated implicit nullable types.

Steps to reproduce

Use in a PHP 8.4 environment

Proposed resolution

Use explicit nullable types (compatible with PHP 7.1+ so no compatibility concerns given Drupal core PHP minimums)

Does change function signatures so may be best to have a new major version

Issue fork geofield-3492426

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nickdickinsonwilde created an issue. See original summary.

nickdickinsonwilde opened merge request !38

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Status: Active » Needs review
ekes’s picture

ekes commented
Status: Needs review » Reviewed & tested by the community

Was just coming here to do something just like this. Patch adds nullable to all declarations that have a NULL default, and shuts up our 8.4 test errors \o/

itamair’s picture

itamair commented
Status: Reviewed & tested by the community » Fixed

Thanks here. Confirming RTBC ... going to merge this.
Going also to extend all this to other Classes methods still Missing proper parameter's type declaration.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.