Using hooks_converted container parameter changes $dir during hook collection breaking collection of oop hooks.

Problem/Motivation

Marked critical because oop hooks won't get picked up for modules marked as converted.
I added a note to the cr referencing this issue.

While working on #3491275: Mark fully converted core modules as converted to OOP hooks History has no procedural hooks.

Marking history as converted

parameters:
  history.hooks_converted: true

This test fails: core/modules/history/tests/src/Kernel/Views/HistoryTimestampTest.php
We need to include .module and / inc files even if we do not scan them.

Apply this patch and run the test and it passes.

Steps to reproduce

.

Proposed resolution

Remove the directory check.
The change looks bigger than it is, it is just removing this:

// Check only hook classes.
    if ($skip_procedural) {
      $dir = $dir . '/src/Hook';
    }

and the wrapping if
if (is_dir($dir)) {

Changing the directory breaks the iterator.

We didn't see this in the original issue because the original issue only used the container parameter in one module and that module did not have hook classes.

Remaining tasks

N/A

User interface changes

N/A

Introduced terminology

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A