Problem/Motivation

Prose and not-prose use is not convincing. We should remove prose class from page template et put it precisely everywhere we need it, for instance:

  • in core & system blocks templates
  • in field--text.html.twig template
  • in patterns & styles library templates
  • etc ...

Proposed resolution

  • Keep typography plugin
  • Remove prose from page.html.twig
  • Remove not-prose from all components where it's used
  • Add prose and not-prose classes to pattern library templates
  • Add prose class to block page title

Issue fork ui_suite_daisyui-3491291

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

g4mbini created an issue. See original summary.

g4mbini’s picture

g4mbini
Primary language French
Location Ruvo di Puglia (BA)
commented
Assigned: Unassigned » g4mbini
mortona2k’s picture

mortona2k commented

.prose is currently on the page wrapper.

Components that are not prose, like ol/ul used in menus need to be overridden.

I think the best way to use tailwind typography in drupal is to set the .text-formatted class and use field--text.html and related templates from starterkit theme which attaches it to the right fields. Or use that template with .prose.

I'd rather set the style where needed than set it globally and have to unset it on component elements.

mortona2k opened merge request !59

g4mbini’s picture

g4mbini
Primary language French
Location Ruvo di Puglia (BA)
commented
Title: [4.0.0-alpha8] Replace hardcoded use of not-prose class by boolean prop » [5.0.x] Replace hardcoded use of not-prose class by boolean prop
g4mbini’s picture

g4mbini
Primary language French
Location Ruvo di Puglia (BA)
commented
Title: [5.0.x] Replace hardcoded use of not-prose class by boolean prop » [4.0.x-beta1] Rework typography plugin management
Assigned: g4mbini » Unassigned
Issue summary: View changes
Status: Active » Needs work
g4mbini’s picture

g4mbini
Primary language French
Location Ruvo di Puglia (BA)
commented
Issue summary: View changes
g4mbini’s picture

g4mbini
Primary language French
Location Ruvo di Puglia (BA)
commented

@fb-multimedia is taking care of the work

fboulanger’s picture

fboulanger
Primary language French
commented
Assigned: Unassigned » fboulanger
g4mbini’s picture

g4mbini
Primary language French
Location Ruvo di Puglia (BA)
commented
Assigned: fboulanger » g4mbini
g4mbini’s picture

g4mbini
Primary language French
Location Ruvo di Puglia (BA)
commented
Issue summary: View changes

g4mbini opened merge request !72

  • g4mbini committed 9dc9a2cb on 4.0.x 
    Issue #3491291 by mortona2k, g4mbini, fb-multimedia: [4.0.x-beta1]...
g4mbini’s picture

g4mbini
Primary language French
Location Ruvo di Puglia (BA)
commented
Status: Needs work » Fixed
g4mbini’s picture

g4mbini
Primary language French
Location Ruvo di Puglia (BA)
commented
Assigned: g4mbini » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

g4mbini closed merge request !59