Problem/Motivation

For example , Heading is hardcoded in Alert component as h3.

Replace all hardcoded headings by prop definition like in card component.

CommentFileSizeAuthor
#4 Replace-twig-hardcoded-headings-by-prop-definition-3491290.patch508 bytesniharika.s

Issue fork ui_suite_daisyui-3491290

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

g4mbini created an issue. See original summary.

g4mbini’s picture

g4mbini
Primary language French
Location Ruvo di Puglia (BA)
commented
Issue summary: View changes
niharika.s’s picture

niharika.s commented
Assigned: Unassigned » niharika.s
niharika.s’s picture

niharika.s commented
Assigned: niharika.s » Unassigned
Status: Active » Needs review
StatusFileSize
new Replace-twig-hardcoded-headings-by-prop-definition-3491290.patch508 bytes

I have applied the changes please review it .

g4mbini’s picture

g4mbini
Primary language French
Location Ruvo di Puglia (BA)
commented

Thanks for the patch @niharika.s

Can you check if there are other components in the same case ?

Also after that, can you provide a Merge Request ?

niharika.s’s picture

niharika.s commented
Assigned: Unassigned » niharika.s

niharika.s opened merge request !53

niharika.s’s picture

niharika.s commented
Assigned: niharika.s » Unassigned
g4mbini’s picture

g4mbini
Primary language French
Location Ruvo di Puglia (BA)
commented
Status: Needs review » Needs work
niharika.s’s picture

niharika.s commented
Assigned: Unassigned » niharika.s

@g4mbini i am working on it.

niharika.s’s picture

niharika.s commented
Assigned: niharika.s » Unassigned
Status: Needs work » Needs review

I have applied the changes and please let me know if any other adjustment required.

g4mbini’s picture

g4mbini
Primary language French
Location Ruvo di Puglia (BA)
commented
Status: Needs review » Needs work
niharika.s’s picture

niharika.s commented
Status: Needs work » Needs review

I've made the changes on my side and applied them in the MR. Let me know if you need any further adjustments or if there's anything else you'd like me to address.

g4mbini’s picture

g4mbini
Primary language French
Location Ruvo di Puglia (BA)
commented
Status: Needs review » Needs work
g4mbini’s picture

g4mbini
Primary language French
Location Ruvo di Puglia (BA)
commented

g4mbini opened merge request !67

  • g4mbini committed 3b81926a on 4.0.x 
    Issue #3491290 by g4mbini: Replace twig hardcoded headings by prop...
g4mbini’s picture

g4mbini
Primary language French
Location Ruvo di Puglia (BA)
commented
Status: Needs work » Fixed
g4mbini’s picture

g4mbini
Primary language French
Location Ruvo di Puglia (BA)
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.