Problem/Motivation

In the Olivero theme, there is a table UI issue in the admin section.

Steps to reproduce

Step1 : Install Drupal
Step2 : Set Olivero as the administration theme.
Step3 : Go to /admin/structure/types/manage/article/permissions
Step4 : When scrolling the table, the sticky header overlaps with the tbody text.

table issue

Proposed resolution

Add a background color to the table's sticky header to resolve this issue.

suggestion

It would be better if we could improve the table UI for the Olivero admin theme.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#11 AwesomeScreenshot-12_12_2024,1_45_39PM.mp4919.94 KBpinesso
#10 Macbook-Air-drupal.ddev_.site_.png235.9 KBsaurav-drupal-dev
Table-issue.png327.34 KBdjsagar

Issue fork drupal-3490587

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

djsagar created an issue. See original summary.

niharika.s’s picture

niharika.s commented
Assigned: Unassigned » niharika.s

djsagar opened merge request !10388

djsagar changed the visibility of the branch 3490587-Table to hidden.

niharika.s’s picture

niharika.s commented
Assigned: niharika.s » Unassigned
quietone’s picture

quietone commented
Version: 11.1.x-dev » 11.x-dev

Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.

djsagar opened merge request !10395

djsagar’s picture

djsagar commented
Status: Active » Needs review

Created MR, please review.

Thanks!

saurav-drupal-dev made their first commit to this issue’s fork.

saurav-drupal-dev’s picture

saurav-drupal-dev commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Macbook-Air-drupal.ddev_.site_.png235.9 KB

I have tested the issue its fixed RTBC+ also pipeline lint issue is fixed as well.

fixed

pinesso’s picture

pinesso commented
StatusFileSize
new AwesomeScreenshot-12_12_2024,1_45_39PM.mp4919.94 KB

I confirmed the issue has been fixed. Please see the attached video as evidence.

Thank you!

quietone’s picture

quietone commented
Title: Table UI issue in the Olivero theme. » Table UI issue in the Olivero theme
Issue summary: View changes
Status: Reviewed & tested by the community » Needs work
Issue tags: +Usability, +Needs title update, +Needs issue summary update

Thanks for submitting a fix for this.

After reading the issue summary I see a couple of things to be done before a review.

First, this is a usability issue, so tagging according to the Usability gate.

The title should be a description of what is being fixed or improved. The title is used as the git commit message so it should be meaningful an concise. See List of issue fields.

And lets make it clear to the reviewed which MR is to be reviewed, The issue summary should have only one MR to be reviewed and the others should be hidden.

nod_ closed merge request !10388

nod_ closed merge request !10395

  • nod_ committed 7afad30a on 11.x 
    Issue #3490587 by djsagar, saurav-drupal-dev, pinesso: Table UI issue in...
nod_’s picture

nod_
Primary language French
Location Lille
commented
Issue summary: View changes
Status: Needs work » Fixed
Issue tags: -Usability, -Needs title update, -Needs issue summary update

Committed 7afad30 and pushed to 11.x. Thanks!

nod_’s picture

nod_
Primary language French
Location Lille
commented
Title: Table UI issue in the Olivero theme » Sticky header background missing in Olivero

Sorry I didn't see the new comment before committing. that's what I get for keeping my tabs opened too long.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.