Closed (fixed)
Project:
Drupal core
Version:
11.1.x-dev
Component:
composer
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
27 Nov 2024 at 09:53 UTC
Updated:
23 Dec 2024 at 12:34 UTC
Jump to comment: Most recent
Comments
Comment #3
spokjeComment #5
spokjeComment #6
smustgrave commentedSame as the 10.5 believe this is good. Didn't notice any issues locally.
Comment #7
spokjeDependency php-tuf/composer-stager with stability RC does not meet minimum stability stable.Unsure if this dependency is allowed to be RC, or flew in under the radar when MINIMUM_STABILITY was lowered to accommodate SF.
So would need some confirmation on that before lowering MINIMUM_STABILITY to 'RC' again.
Otherwise things look fine.
Comment #8
spokjeComment #10
andypostThe
php-tuf/composer-stageris an experimental module's dependency so should not block releaseComment #11
andypostComment #12
andypostComment #13
catchWe can keep minimum stability as rc in this issue but we should open an explicit tracking issue for php-tuf to get to a stable release.
Another possibility might be to move the library to a dev dependency until package_manager is beta, but that might break package_manager tests so could be more trouble than it's worth.
Comment #14
spokjeComment #16
spokjeWell that's me on a Windows git-bash based system out of the running for core work...
I've added the tracking issue, somebody needs to pick this up and/or also my JS-dependency updates.
Comment #17
spokjeComment #18
longwaveUnless we relax this in ComposerProjectTemplatesTest we won't be able to have tests passing on 11.1.0:
This prevents us from releasing a stable version of core with RC dependencies, or an RC with beta dependencies, etc.
Comment #19
longwaveRe #16 I reposted that in #3471494: Add an icon management API, hopefully we can do a quick fix or just remove it for now.
Comment #20
longwaveChanged minimum stability back to RC.
Comment #21
andypostRebased, reverted to
php-tuf/composer-stager:v2.0.0-rc5as 2 tests failing reproducible and update coder to 8.3.26Comment #22
andyposton second time package manager's build tests passed with rc5
Comment #23
andypostAnd it passed on PHP 8.4
So reverted back to latest as it was test flux
Comment #24
andypostComment #25
spokjeComment #26
andypostThis week is enough updates for release
Comment #27
spokjeComment #28
spokjeComment #29
longwaveCommitted fc9c4c2 and pushed to 11.x. Thanks!
Committed bd2b1c3 and pushed to 11.1.x. Thanks!