Problem/Motivation

Evaluate if instead of altering form with the plugin manager, create a form element.

Issue fork ui_styles-3490142

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

grimreaper created an issue. See original summary.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: Unassigned » grimreaper

grimreaper opened merge request !71

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Commit message.

Issue #3490142 by grimreaper, pdureau: Move styles manager form alter logic to a form element.

- do not save empty config entries
- Rework ui_styles_attributes source regarding last changes in UIP2
- Allow ui_styles_attributes source to set other attributes
- Fix ui_styles_ui_patterns config schema

@todo Create tests on the form element.

@pdureau I ask you some macro questions in MR.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Title: Evaluate if better to provide a form element » Introduce dedicated form element
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Active » Needs work
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » pdureau
Status: Needs work » Needs review

Waiting feedbacks before converting stylesManager::alterForm tests to the Form element tests.

pdureau’s picture

pdureau commented
Assigned: pdureau » grimreaper
Status: Needs review » Needs work

Very cool. OK with everything

  • grimreaper committed 06c02af5 on 8.x-1.x 
    Issue #3490142 by grimreaper, pdureau: Move styles manager form alter...
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Status: Needs work » Fixed
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: Unassigned » grimreaper
Status: Fixed » Needs work
Related issues: +#3501400: DX: attribute prop source trait?

Remove code that is now in https://www.drupal.org/project/ui_patterns/issues/3501400

grimreaper opened merge request !73

  • grimreaper committed 244df5ba on 8.x-1.x 
    Issue #3490142 by grimreaper, pdureau: Remove code now in public UIP API...
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.