Problem/Motivation

Follow-up from #3467309: Replace abandoned, not working with latest stylelint, leon0399/stylelint-formatter-gitlab with gitlab-formatters/stylelint-formatter-gitlab

I think the output could be improved - we should fix up the paths so the link in https://git.drupalcode.org/issue/drupal-3487817/-/pipelines/340184/codeq... is clickable - but that can happen in a followup.

@longwave in #3467309-19

When clicking on a link in the GitLab report linked in the quote above, we're not landing on the file that's in the URL text.
From the looks of it there's a core/ missing in the URL.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3489795

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
Title: Link output of CSS eslinting on GitLab correctly » Link output of CSS linting (stylelint) on GitLab correctly
spokje’s picture

spokje
Primary language Dutch
commented
Title: Link output of CSS linting (stylelint) on GitLab correctly » Correctly link output of CSS linting (stylelint) on GitLab
Anonymous’s picture

Anonymous (not verified) commented

akulsaxena made their first commit to this issue’s fork.

akulsaxena opened merge request !10340

Anonymous’s picture

Anonymous (not verified) commented

@spokje
I didn't realise the Styleint Error has already been resolved and only the linking of CSS output is not correct.
Reverted the changes on MR.

sourav_paul’s picture

sourav_paul
Location Kolkata
commented

I've checked that updated stylelint-formatter: gitlab-formatters/stylelint-formatter-gitlab is already in 11.x..

Hence please move it into correct state...

spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes

Tried to clarify the IS, since there seems to be a lot of misunderstanding of what we're trying to accomplish in this issue.

spokje’s picture

spokje
Primary language Dutch
commented
Title: Correctly link output of CSS linting (stylelint) on GitLab » Correctly link output of files with problems in CSS linting (stylelint) on GitLab
spokje’s picture

spokje
Primary language Dutch
commented
Title: Correctly link output of files with problems in CSS linting (stylelint) on GitLab » Correctly link output of files with problems in CSS linting (stylelint) report on GitLab
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

I think it's because of this at the start of the job

$ mkdir /build;
$ cp -Ria $CI_PROJECT_DIR/* /build/
$ cd /build

The paths are relative to the original directory instead of /build - it would be better if we could just run the linter in place?

spokje opened merge request !10683

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.