Problem/Motivation

Upgrading to PHP 8.3 is slightly blocked on lcobucci/clock, as 2.3.0 does not allow PHP 8.3. In https://github.com/lcobucci/jwt/pull/986 it was allowed to support version 3.0, which supports PHP 8.3.

Otherwise the clock package downgrades to 2.2.0

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork indieweb-3489327

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mglaman created an issue. See original summary.

swentel’s picture

swentel commented

So requiring 4.3.0 seems to work fine, although I have some test failures locally on my own site, but I'll have to double check. Will rewind my local drupal install to 10.x to see if that goes better (and hopefully find some time to upgrade this module to work with 11.x too heh)

  • swentel committed 85611344 on 8.x-1.x 
    Issue #3489327: Allow lcobucci/jwt 4.3.0 for PHP 8.3 support
swentel’s picture

swentel commented
Status: Active » Fixed

done, will push a new release in a couple of minutes.

swentel’s picture

swentel commented
Status: Fixed » Closed (fixed)
swentel’s picture

swentel commented
Version: 8.x-2.x-dev » 8.x-1.x-dev
Status: Closed (fixed) » Active

crap, testbot doesn't have sodium extension installed, checking ..

swentel opened merge request !3

swentel’s picture

swentel commented

hmm, looks like this is blocked on https://www.drupal.org/project/drupalci_environments/issues/3387737#comm...

(although sodium is bundled within PHP normally afaict from php7.2, so not sure why the package requires it in composer.json as the minimum php requirement is 7.4)

  • swentel committed 92dd4cc8 on 8.x-1.x 
    Issue #3489327: Allow lcobucci/jwt 4.3.0 for PHP 8.3 support
swentel’s picture

swentel commented
Status: Active » Fixed

Ok, used sodium_compat polyfill, works fine!

swentel’s picture

swentel commented
Status: Fixed » Closed (fixed)
swentel’s picture

swentel commented
Status: Closed (fixed) » Needs work

Hmm, can't install latest release on my local machine, or on server, let's see how to get around this

swentel opened merge request !5

  • swentel committed def34703 on 8.x-1.x 
    Issue #3489327: Allow lcobucci/jwt 4.3.0 for PHP 8.3 support
swentel’s picture

swentel commented

Remove the sodium replace and compat, but that means the testbot will fail always now

swentel’s picture

swentel commented
Title: Allow lcobucci/jwt 4.3.0 for PHP 8.3 support » Allow lcobucci/jwt 4.3.0 for PHP 8.3 support triggers ext-sodium testbot problems
swentel’s picture

swentel commented
Related issues: +#3387737: Split PHP image into php(cli/apache) and yarn(node/nightwatch)

swentel opened merge request !6

  • swentel committed 0e587bc5 on 8.x-1.x 
    Issue #3489327: Allow lcobucci/jwt 4.3.0 for PHP 8.3 support triggers...
swentel’s picture

swentel commented
Status: Needs work » Fixed

Ok using aliases makes this work as far as I can see, finally!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.