We need this message to be configurable to override it per environment via config split or settings.php

Issue fork migration_notify-3489204

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

leymannx created an issue. See original summary.

norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented
Assigned: Unassigned » norman.lol

Working on it RN

leymannx opened merge request !5

norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented
Assigned: norman.lol » Unassigned
Status: Active » Needs review

I was just following the existing logic while keeping it extendable at the same time, adding a new section "Notification messages" at the end of the config form to set just a "Stuck message" for now. In all places it falls back to the existing messages which already existed.

fjgarlin’s picture

fjgarlin commented
Status: Needs review » Reviewed & tested by the community

We don't have tests in the module, but I've reviewed the code and it does look good and there is no regression. Thanks for this!

  • fjgarlin committed d9b4f5cc on 1.x authored by leymannx 
    Issue #3489204 by leymannx: Make stuck migrations message configurable
fjgarlin’s picture

fjgarlin commented
Status: Reviewed & tested by the community » Fixed

A nice follow-up for this module might be to create a config/schema/migration_notify.schema.yml file, which I think might be required in future versions of Drupal, but don't worry if you don't have the time. I appreciate the fixes.

norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented

Yeah, I thought the exact same about the schema. Follow-up issue and I'm happy to help here. 🤝

norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented

Plus /install/config/ to set the initial values.

fjgarlin’s picture

fjgarlin commented

Awesome! Thanks so much!

In case this other module might be useful, I'm just putting it out here: https://www.drupal.org/project/config_notify
I actually created the above first, and then had the idea for this one. They follow very similar principals.

norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented

You mean we might also add this feature of a configurable message there as well?

fjgarlin’s picture

fjgarlin commented

If you want 🙂

I think that module might have some more settings but can’t remember if messages were configurable.

fjgarlin’s picture

fjgarlin commented

But it was mostly to bring the module under your radar too in case it wasn’t.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.