Stop calling node_add_body_field() from NodeTypeForm

Alright, started an MR. Let's see what breaks.

Discussed this briefly with @Gábor Hojtsy in slack and he approved this change from a product manager perspective. It changes what happens with the form, but since the field is already deletable it doesn't affect other expectations outside the UI.

OK, so all PHP tests are now passing but Nightwatch tests are failing because they need to manually add the body field after creating a new content type. I have no Nightwatch experience.

Tried clicking the button in a different way etc. but did not really get anywhere.

I think this makes sense, it fits into the philosophy we are taking Drupal core towards, being more of an enabler that other layers can rely on, not trying to be a complete solution.

Can we get a follow-up to fix the nightwatch tests. I will do that but after we land this.

We also need a change record so we can highlight the behaviour change in the 11.1 release. Drupal has added a body field for you for a very long time.

Well that certainly is a workaround. :) I feel okay RTBCing this because it's different than the approach I took. Effectively a different patch.

This is important for the future of Drupal CMS so, knowing that we have follow-up issues in place to address this properly and to deprecate/remove this accursed function, and that if we don't do this now, we won't get another chance until 11.2...

...let it fly.

Here's the follow-up #3489266: Deprecate node_add_body_field().

I can draft the CR now too.

Adding issue credit.

Committed and pushed dd2982b5324 to 11.x and c4e3cfcfe05 to 11.1.x. Thanks!

Created those follow ups for Nightwatch tests which are needed now for #3489266: Deprecate node_add_body_field()

#3517023: Convert ckEditor5CodeSyntaxTest to WebDriver test
#3517024: Convert ckEditor5EditorHeightTest to WebDriver test