Problem/Motivation

phpstan step in gitlab-ci pipeline is failing: https://git.drupalcode.org/project/lupus_decoupled/-/jobs/3397370

 ------ ----------------------------------------------------------------------------------- 
  Line   modules/lupus_decoupled_ce_api/src/EventSubscriber/FrontendRedirectSubscriber.php  
 ------ ----------------------------------------------------------------------------------- 
  112    Variable $redirect_url might not be defined.                                       
 ------ -----------------------------------------------------------------------------------

Proposed resolution

The easiest solution seems to wrap the setResponse into if statement that checks if $redirect_url is set.

Issue fork lupus_decoupled-3488658

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

useernamee created an issue. See original summary.

kul.pratap’s picture

kul.pratap commented
Assigned: Unassigned » kul.pratap

kul.pratap opened merge request !111

kul.pratap’s picture

kul.pratap commented
Assigned: kul.pratap » Unassigned
Status: Active » Needs review

Now phpstan pipeline is passing with no errors and warnings, Please review.

useernamee’s picture

useernamee commented
Status: Needs review » Needs work
kul.pratap’s picture

kul.pratap commented
Status: Needs work » Needs review
useernamee’s picture

useernamee commented
Status: Needs review » Reviewed & tested by the community

Code looks good, thank you @kul.pratap

useernamee’s picture

useernamee commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.