Problem/Motivation

As with components with loops on slots, it is no more possible to inject a div like in #3486050: [2.0.0-beta5] Layout Builder: fix d&d remove temporarily UI Styles support with the UI Styles classes, check components if proper prop attributes should not be created instead.

Then decide if we will go on a manual prop attributes declared or introducing a mechanism.

accordion: ok
accordion_item: don't change for the moment
- accordion-header attributes
- (button_attributes)
- (content attributes)
- accordion-body attributes
alert:
- prop heading level
- heading attributes
badge: ok
blockquote: don't change for the moment
- blockquote attributes?
- blockquote footer attributes?
breadcrumb: ok
button: ok
button_group: ok
button_toolbar: ok
card:
- card header: https://getbootstrap.com/docs/5.3/components/card/#mixins-utilities
- card footer: https://getbootstrap.com/docs/5.3/components/card/#mixins-utilities
- image_col_classes to convert
- content_col_classes to convert
- for horizontal variant: row attributes
card_body:
- card subtitles attributes: https://getbootstrap.com/docs/5.3/components/card/#titles-text-and-links
- card title
- card text
card_group: ok
card_overlay: same as card_body
carousel: ok
carousel_item:
- carousel caption: https://getbootstrap.com/docs/5.3/components/carousel/#captions
- image attributes? don't change for the moment
close_button: ok
dropdown: don't change for the moment
- dropdown-menu attributes? out of scope https://getbootstrap.com/docs/5.3/components/dropdowns/#text ?
figure: don't change for the moment
- image attributes?
list: ok
list_group: ok
list_group_item: ok
modal:
- modal title: https://getbootstrap.com/docs/5.3/components/modal/#live-demo
- modal header
- modal body
- modal footer
nav: ok
navbar: ok
navbar_nav: ok
offcanvas:
- offcanvas body: https://getbootstrap.com/docs/5.3/components/offcanvas/#placement
- offcanvas title
- offcanvas header
pagination: ok
progress: don't change for the moment
- rework height prop with an attributes prop?
progress_stacked: ok
spinner: ok
table: ok
table_cell: ok
table_row: ok
toast:
- toast header
- toast body
toast_container: ok

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

grimreaper created an issue. See original summary.

grimreaper’s picture

Assigned: grimreaper » pdureau

Put in issue summary.

grimreaper’s picture

Issue summary: View changes
grimreaper’s picture

Assigned: pdureau » grimreaper
Issue summary: View changes

grimreaper’s picture

Assigned: grimreaper » Unassigned
Status: Active » Fixed

  • grimreaper committed b4eb7976 on 5.1.x
    Issue #3488171 by grimreaper, pdureau: Set variables only if needed.
    

  • grimreaper committed 2fa2ab0d on 5.1.x
    Issue #3488171 by grimreaper, pdureau: Add prop attributes when needed
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.