Problem/Motivation

  • Update a .gitlab-ci.yml file to align https://www.drupal.org/project/gitlab_templates/issues/3478044 
    *****************************************************************************************************************************
* _TARGET_CORE=10.3.x
* The _TARGET_CORE variable is deprecated in GitLab Templates version 1.5.10. Instead use
*
* composer:
*   variables:
*     DRUPAL_CORE: 10.3.x
*
* See https://git.drupalcode.org/project/gitlab_templates/-/blob/main/CHANGELOG.md#1510---2024-10-04  
*****************************************************************************************************************************

Issue fork cloud-3487684

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

yas created an issue. See original summary.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Version: 7.x-dev » 8.x-dev

yas opened merge request !2323

yas closed merge request !2323

yas changed the visibility of the branch 3487684-update-a-.gitlab-ci.yml to hidden.

yas changed the visibility of the branch 3487684-update-a-.gitlab-ci.yml-8.x to active.

yas reopened merge request !2323

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Reviewed & tested by the community

Gitlab-ci file updated to remove deprecated _TARGET_CORE

Anonymous’s picture

Anonymous (not verified) commented

Rebase looks good

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@akulsaxena

Thank you for your review. I’ll merge the patch into 7.x and 8.x; and close this issue as Fixed.

  • yas committed 4d4f9cf9 on 8.x 
    Issue #3487684 by yas: Update a .gitlab-ci.yml file (4)

  • yas committed 1c9ff011 on 7.x 
    Issue #3487684 by yas: Update a .gitlab-ci.yml file (4)
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
Anonymous’s picture

Anonymous (not verified) commented

Hi @yas,

I followed and tested the issue to confirm its resolution. Once I verified that the issue was resolved, I also moved it to the "Reviewed and Tested by Community" state.

As I contributed to this process, I would appreciate it if my effort could be acknowledged with a credit. This recognition would be highly motivating and encourage me to continue contributing.

Thank you for your attention to this matter. I look forward to your response.

Best regards,
Akul

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@akulsaxena

Thank you for your message and for taking a look at this issue.

I appreciate your interest and efforts. In this particular case, the issue was already resolved and the fix was confirmed by the automated testing, therefore additional contributions were minimal (The Drupal credit system doesn't add your credit by default, too), so I have decided not to add additional credits. However, your enthusiasm and willingness to contribute are greatly appreciated.

I encourage you to continue participating in the community, and I look forward to collaborating with you on future issues.

Thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.