Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
Most of core has now been converted to OOP hook implementations. Let's deprecate the ones that can be converted.
@catch mentioned this is likely 11.2 only.
Steps to reproduce
N/A
Proposed resolution
Deprecate within the call to the function.
Remaining tasks
Agree on messaging and exceptions
How to handle contrib adding exceptions (should we handle this)
How to handle test exceptions
Tie together the check in deprecation with the check in hook collector pass so they are in sync
User interface changes
N/A
Introduced terminology
N/A
API changes
N/A
Data model changes
N/A
Release notes snippet
N/A
Issue fork drupal-3487590
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
nicxvan commentedComment #3
nicxvan commentedComment #5
nicxvan commentedComment #6
catchI had assumed we'd trigger E_USER_DEPRECATED in hook discovery, once per module when we find a procedural hook, should be cheaper?
Comment #7
nicxvan commentedHook collector picks up all functions that start with module name.
Comment #8
prudloff commentedIt looks like the patch only triggers a deprecation for hooks called by ModuleHandler::invoke() and not those called byModuleHandler::invokeAllWith().
Comment #9
nicxvan commentedYeah this isn't the approach we would take at all. Let me postpone it, not sure on what though.
Comment #10
nicxvan commented