Problem/Motivation

please don't forget what is said in comment 15842958 from #3458561: [1.1.0] Update to DSFR 1.12 :

- The dialog element in the transcription pattern changed to a div in DSFR 1.10

Issue fork ui_suite_dsfr-3487435

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

just_like_good_vibes created an issue. See original summary.

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Title: [1.0.4][1.1.0] transcription pattern update (DSFR 1.10 evolution leftover) » [1.1.0] transcription pattern update (DSFR 1.10 evolution leftover)
Assigned: Unassigned » just_like_good_vibes

just_like_good_vibes opened merge request !144

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Version: 1.0.x-dev » 1.1.x-dev
just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Status: Active » Needs work

we will include the modal component from the trancription component, as seen in https://github.com/GouvernementFR/dsfr/blob/main/src/dsfr/component/tran...

please note, between the component page, the netlify page and the storybook page, it is not div or dialog everywhere.

we will select "dialog" because it will come from the modal component.

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Title: [1.1.0] transcription pattern update (DSFR 1.10 evolution leftover) » [1.1.0] transcription pattern update

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Assigned: just_like_good_vibes » Unassigned
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.