After adding a Container Wrapper Class under Advanced Settings, the class is initially saved and applied successfully, but then if I go back to edit the node and hit save again, even without making additional edits, the class is removed.

dialog window

CommentFileSizeAuthor
#10 Screenshot 2024-12-12 at 12.19.43 PM.png189.36 KBsrdtwc
#10 Screenshot 2024-12-12 at 12.23.31 PM.png35.77 KBsrdtwc
#10 Screenshot 2024-12-12 at 12.20.49 PM.png135.36 KBsrdtwc
Screenshot 2024-11-13 at 2.49.24 PM.png52.36 KBsrdtwc

Issue fork uswds_ckeditor_integration-3487334

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

srdtwc created an issue. See original summary.

amplifier’s picture

amplifier commented

I am experiencing this too.

smustgrave’s picture

smustgrave commented
Priority: Normal » Major

this actually needs some major refactoring

smustgrave’s picture

smustgrave commented

So no secret and we got permission to do so but this was forked from ckeditor_bs_grid and bootstrap has container options.

So here we need to to turn that default option to a checkbox to add the container.

Move the container class to that Div vs uswds_grid which isn’t a real uswds class

smustgrave opened merge request !91

smustgrave’s picture

smustgrave commented
Status: Active » Needs review

Try this

  • smustgrave committed f034d997 on 3.1.x 
    Issue #3487334 by srdtwc, smustgrave: Container Wrapper Classes removed...
smustgrave’s picture

smustgrave commented
Status: Needs review » Fixed

Going to go on a limb

smustgrave’s picture

smustgrave commented

Put a warning in the description this was a re write

srdtwc’s picture

srdtwc commented
StatusFileSize
new Screenshot 2024-12-12 at 12.20.49 PM.png135.36 KB
new Screenshot 2024-12-12 at 12.23.31 PM.png35.77 KB
new Screenshot 2024-12-12 at 12.19.43 PM.png189.36 KB

There seem to be a few issues with this upgrade

1) There are a number of errors present. These appear even after a "drush cr".

PHP errors/warnings

2) After creating a page with a grid the wrapper classes are saved successfully, but when I go to edit the grid again a large black triangle appears in CKEditor. I can confirm this did not happen in 3.1.2.

CKE bug

3) Embedded Content appears broken. Any page with an existing Accordion returns an error like this:

accordion error

Additionally, when clicking the "Embedded Content" button when creating a new node, there is a 500 error in the console.

smustgrave’s picture

smustgrave commented

I don't understand how #1 and #3 are related to this issue

srdtwc’s picture

srdtwc commented

Tested again, 1 and 3 were the result of upgrading with --with-dependencies, which upgraded doctrine/deprecations and caused those errors.

2 is still present when upgrading without --with-dependencies.

But I can confirm the intended functionality of being able to save the wrapper classes seems to be working.

smustgrave’s picture

smustgrave commented
Status: Fixed » Needs work

So I don't forget to take a look

smustgrave’s picture

smustgrave commented

This whole plugin needs to be redone, probably going to start a new branch

smustgrave’s picture

smustgrave commented
Version: 3.1.2 » 3.2.x-dev

smustgrave opened merge request !98

smustgrave’s picture

smustgrave commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.