Problem/Motivation

It's been a long road, so this was delegated to a follow up.
#3396166: Convert entity type discovery to PHP attributes

Some Attributes are missing the trailing comma and need the last )] brought to the next line.

  • core/lib/Drupal/Core/Datetime/Entity/DateFormat.php
  • core/lib/Drupal/Core/Entity/Entity/EntityFormDisplay.php
  • core/lib/Drupal/Core/Entity/Entity/EntityFormMode.php
  • core/lib/Drupal/Core/Entity/Entity/EntityViewDisplay.php
  • core/lib/Drupal/Core/Entity/Entity/EntityViewMode.php
  • core/modules/config/tests/config_test/src/Entity/ConfigTest.php
  • core/modules/language/src/Entity/ContentLanguageSettings.php
  • core/modules/media/src/Entity/Media.php
  • core/modules/media/src/Entity/MediaType.php
  • core/modules/menu_link_content/src/Entity/MenuLinkContent.php

This will make a good novice issue once the other issue lands.

Steps to reproduce

Review attributes

Proposed resolution

Add trailing comma and hit enter

Remaining tasks

#3396166: Convert entity type discovery to PHP attributes
Create MR

User interface changes

N/A

Introduced terminology

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

Issue fork drupal-3487088

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nicxvan created an issue. See original summary.

nicxvan’s picture

nicxvan commented
Title: [pp-1] Fix trailing comma in entity type Attribute declarations. » [pp-1] Fix trailing comma in entity type Attribute declarations
quietone’s picture

quietone commented
Issue summary: View changes
Status: Active » Postponed

Adding postponed item to the list of remaining tasks per the issue summary field documentation, remaining task.

nicxvan’s picture

nicxvan commented
Title: [pp-1] Fix trailing comma in entity type Attribute declarations » Fix trailing comma in entity type Attribute declarations
Issue summary: View changes
Status: Postponed » Active
Issue tags: +Novice

The issue this was postponed on just landed.

sayan_k_dutta’s picture

sayan_k_dutta commented
Assigned: Unassigned » sayan_k_dutta
sayan_k_dutta’s picture

sayan_k_dutta commented
Assigned: sayan_k_dutta » Unassigned
lavanyatalwar’s picture

lavanyatalwar commented
Assigned: Unassigned » lavanyatalwar

I'll look into this.

lavanyatalwar opened merge request !10180

lavanyatalwar’s picture

lavanyatalwar commented

Hi @nicxvan,
Fixed the trailing commas problem.
Kindly check :)

lavanyatalwar’s picture

lavanyatalwar commented
Assigned: lavanyatalwar » Unassigned
Status: Active » Needs review

Updating the status to NR

nicxvan’s picture

nicxvan commented
Status: Needs review » Reviewed & tested by the community

I checked and all have been updated.

Just a friendly reminder, before setting needs review you should ensure tests are passing.

There were two failures, both were random so rerunning them they passed, but that is something to monitor before setting needs review

  • quietone committed 9f2e2c69 on 11.1.x 
    Issue #3487088 by lavanyatalwar, nicxvan: Fix trailing comma in entity...

  • quietone committed 91fc116a on 11.x 
    Issue #3487088 by lavanyatalwar, nicxvan: Fix trailing comma in entity...
quietone’s picture

quietone commented
Version: 11.x-dev » 11.1.x-dev
Status: Reviewed & tested by the community » Fixed
Issue tags: +Needs followup

@lavanyatalwar, Welcome to Drupal!

Thanks for tidying this up.

There should also be a coding standards issue so we can ultimately have a sniff that will detect such errors. Therefor, tagging for a following.

Committed to 11.x and 11.1.x, Thanks!

quietone closed merge request !10180

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.