Problem/Motivation

Maybe only for the directory not found error.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3486481

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

berdir created an issue. See original summary.

berdir’s picture

Confirmed that it's apparently only the "foo is not a directory" message that's not an error.

mxr576’s picture

I have also run into this problem that an error only appeared on STDOUT and not on STDERR but that has not been reported by Recipe installer.

mxr576’s picture

Issue tags: +testing

With original implementation it was extremely painful for us figuring out that part of the Drupal 11.2.0 update an assert breaks in our code since the assertion error was only visible on stdout. "Failed asserting that 1 is identical to 0." was also not really helpful, so it got also improved in the MR.

STDOUT:
[notice] A backup checkpoint was not created because nothing has changed since the "Backup before the 'Foo' recipe." checkpoint was created.
AssertionError: assert(property_exists($index, 'original')) in assert() (line 51 of /mnt/files/local_mount/drupal/modules/foo/src/Bar.php).


STDERR:
0/7 [░░░░░░░░░░░░░░░░░░░░░░░░░░░░]
Applying recipe

1/7 [▓▓▓▓░░░░░░░░░░░░░░░░░░░░░░░░]
Installed Image module.

2/7 [▓▓▓▓▓▓▓▓░░░░░░░░░░░░░░░░░░░░]
Installed Comment module.

3/7 [▓▓▓▓▓▓▓▓▓▓▓▓░░░░░░░░░░░░░░░░]
Installed Database Search module.

4/7 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓░░░░░░░░░░░░]
Installed Database Search Defaults module.


Failed asserting that 1 is identical to 0.
/mnt/files/local_mount/build/web/core/tests/Drupal/FunctionalTests/Core/Recipe/RecipeTestTrait.php:89
/mnt/files/local_mount/drupal/recipes/Foo/tests/src/Funtional/BarTest.php:54
mxr576’s picture

Status: Active » Needs review
attila.fekete’s picture

Status: Needs review » Reviewed & tested by the community

Looks good, tested.

mxr576’s picture

The patch saved the day today again, because it helped with identifying a missing dependency inside a recipe that was completely hidden before the patch, what we have seen is just 1 !== 0 and recipe application failed.

Process exit code mismatch.
Expected: 0
Actual: 1

STDOUT:
Error: Call to a member function getConfigDependencyName() on null in Drupal\Core\Entity\EntityDisplayBase->calculateDependencies() (line 302 of /var/www/html/build/web/core/lib/Drupal/Core/Entity/EntityDisplayBase.php).

  • alexpott committed c70b7685 on 11.2.x
    Issue #3486481 by mxr576, berdir: Recipe install command prints out to...
alexpott’s picture

Version: 11.x-dev » 11.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed edbbe5c and pushed to 11.x. Thanks!
Committed c70b768 and pushed to 11.2.x. Thanks!

More information to help people makes sense.

  • alexpott committed edbbe5c1 on 11.x
    Issue #3486481 by mxr576, berdir: Recipe install command prints out to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.