Is there any plan, when will protected pages be on Drupal 11?

regards Hobbs

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

drwilliamhobbs created an issue. See original summary.

mark_fullmer made their first commit to this issue’s fork.

mark_fullmer’s picture

Assigned: drwilliamhobbs » Unassigned
Status: Needs work » Needs review

Based on the analysis below and functional testing, this should be ready to merge and a new 8.x-1.7 release provided with Drupal 11 compatibility

Auditor checklist

[x] Deprecated Drupal code is remediated -- no deprecations found using Rector or Upgrade Status, or
[x] Deprecated PHP code is remediated -- change, noted below.
[x] Custom code is compatible with jQuery 4 -- none present
[x] Custom code core_version_requirement indicates Drupal 11 compatibility
[x] This module's composer.json file does not require any changes for Drupal 11 compatibility
[x] I updated the GitlabCI file to run Functional tests against both Drupal 10 and Drupal 11.
[x] Existing functional tests pass on Drupal 10 and Drupal 11

Drupal-Rector Audit of Drupal deprecations

1 file with changes
===================

1) web/modules/contrib/protected_pages/src/EventSubscriber/ProtectedPagesSubscriber.php:134

    ---------- begin diff ----------
@@ @@
   /**
    * {@inheritdoc}
    */
-  public static function getSubscribedEvents() {
+  public static function getSubscribedEvents(): array {
     $events[KernelEvents::RESPONSE][] = ['checkProtectedPage'];
     return $events;
   }
    ----------- end diff -----------

Applied rules:
 * ProtectedStaticModulesPropertyRector
 * AddReturnTypeDeclarationRector


 [OK] 1 file would have been changed (dry-run) by Rector                                                                

Audit of deprecated PHP <8.3 calls
If no errors are listed below, php-compatibility did not find any.

.......... 10 / 10 (100%)

mmarler’s picture

I'm getting a fatal error in Drupal 11.0.9 when the workspaces module is enabled:

TypeError: Drupal\protected_pages\EventSubscriber\ProtectedPagesSubscriber::__construct(): Argument #1 ($aliasManager) must be of type Drupal\path_alias\AliasManager, Drupal\workspaces\WorkspacesAliasManager given, called in /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 259 in Drupal\protected_pages\EventSubscriber\ProtectedPagesSubscriber->__construct() (line 91 of /app/web/modules/contrib/protected_pages/src/EventSubscriber/ProtectedPagesSubscriber.php).

mmarler’s picture

Status: Needs review » Needs work
mmarler’s picture

mmarler’s picture

Status: Needs work » Needs review
drwilliamhobbs’s picture

Is it possible to get an Updated-Zipfile?

abhi_khandelwal made their first commit to this issue’s fork.

mark_fullmer’s picture

Is it possible to get an Updated-Zipfile?

I think the best way to go about getting a "download" of this would be to use Git to clone the issue fork & branch (see the "Show commands" expandable near the top of this issue).

patelh84’s picture

StatusFileSize
new16.82 KB

The #MR32 works for both Drupal 10 and Drupal 11. Attaching the upgrade status screenshot for reference. Moving the issue to RTBC.

patelh84’s picture

Status: Needs review » Reviewed & tested by the community

oksana-c made their first commit to this issue’s fork.

oksana-c credited cchiste.

oksana-c’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

xcraftman52’s picture

Can the maintainers provide a timeline for when this compatibility will be provided in a new release? Thanks for all the work you do!

anybody’s picture

@oksana-c could you please tag a new D11 compatible release with priority?

oksana-c’s picture

@anybody, good reminder. done!