Closed (fixed)
Project:
Protected Pages
Version:
8.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Support request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
6 Nov 2024 at 20:09 UTC
Updated:
21 Jan 2025 at 12:21 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #4
mark_fullmerBased on the analysis below and functional testing, this should be ready to merge and a new 8.x-1.7 release provided with Drupal 11 compatibility
Auditor checklist
[x] Deprecated Drupal code is remediated -- no deprecations found using Rector or Upgrade Status, or
[x] Deprecated PHP code is remediated -- change, noted below.
[x] Custom code is compatible with jQuery 4 -- none present
[x] Custom code core_version_requirement indicates Drupal 11 compatibility
[x] This module's composer.json file does not require any changes for Drupal 11 compatibility
[x] I updated the GitlabCI file to run Functional tests against both Drupal 10 and Drupal 11.
[x] Existing functional tests pass on Drupal 10 and Drupal 11
Drupal-Rector Audit of Drupal deprecations
1 file with changes
===================
Comment #5
mmarler commentedI'm getting a fatal error in Drupal 11.0.9 when the workspaces module is enabled:
TypeError: Drupal\protected_pages\EventSubscriber\ProtectedPagesSubscriber::__construct(): Argument #1 ($aliasManager) must be of type Drupal\path_alias\AliasManager, Drupal\workspaces\WorkspacesAliasManager given, called in /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 259 in Drupal\protected_pages\EventSubscriber\ProtectedPagesSubscriber->__construct() (line 91 of /app/web/modules/contrib/protected_pages/src/EventSubscriber/ProtectedPagesSubscriber.php).Comment #6
mmarler commentedComment #7
mmarler commentedI'll apply the patch here: https://www.drupal.org/project/protected_pages/issues/3456307
Comment #8
mmarler commentedComment #9
drwilliamhobbs commentedIs it possible to get an Updated-Zipfile?
Comment #12
mark_fullmerI think the best way to go about getting a "download" of this would be to use Git to clone the issue fork & branch (see the "Show commands" expandable near the top of this issue).
Comment #13
patelh84 commentedThe #MR32 works for both Drupal 10 and Drupal 11. Attaching the upgrade status screenshot for reference. Moving the issue to RTBC.
Comment #14
patelh84 commentedComment #18
oksana-c commentedComment #21
xcraftman52 commentedCan the maintainers provide a timeline for when this compatibility will be provided in a new release? Thanks for all the work you do!
Comment #22
anybody@oksana-c could you please tag a new D11 compatible release with priority?
Comment #23
oksana-c commented@anybody, good reminder. done!