Overview

In the designs the "tabs" ui in the left and right panels appears to be using the Radix Themes Tabs component. However the current implementation has been built using the Segmented Control which doesn't look correct and means that we have to have our own manual state management to control which content is shown (which is built in to the Tabs component out of the box).

Proposed resolution

Replace SegmentedControl in PrimaryPanel.tsx and ContextualPanel.tsx with the Radix Themes Tabs component

User interface changes

CommentFileSizeAuthor
Experience_Builder_-_tabs.png205.72 KBjessebaker

Issue fork experience_builder-3485440

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jessebaker created an issue. See original summary.

shyam_bhatt’s picture

shyam_bhatt
he/him
commented
Assigned: Unassigned » shyam_bhatt

shyam_bhatt changed the visibility of the branch 3485440-update-ui-for to hidden.

shyam_bhatt changed the visibility of the branch 3485440-update-ui-for to active.

shyam_bhatt opened merge request !393

shyam_bhatt’s picture

shyam_bhatt
he/him
commented
Assigned: shyam_bhatt » Unassigned
Status: Active » Needs review

hooroomoo made their first commit to this issue’s fork.

jessebaker’s picture

jessebaker commented
Status: Needs review » Fixed

Thanks @shyam_bhatt I took what you implemented and ran with it - it was really useful. I fixed up the tests and made a few further changes.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.