Problem/Motivation

The module was moved fairly recently to using State API for storing various data, such as last run times and findings for checks. However, some more guidance has become clear regarding the state API, see https://www.drupal.org/node/3177901. As a guideline, the maximum number of entries in the State API as a whole is suggested to be 100. This module alone causes - typically - 123 entries.

Steps to reproduce

* Instal the module
* Run the security checks
* Run the query from the change record and/or modify it to see the actual entries
* See that the number of entries exceeds the maximum number as given as guidance in the change record.

Proposed resolution

Use a dedicated key-value collection, as suggested in the change record.

Remaining tasks

  • Agree this is a good approach
  • Create MR
  • Review
  • Merge

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork security_review-3484859

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

eelkeblok created an issue. See original summary.

eelkeblok’s picture

eelkeblok
he/him
Primary language Dutch
Location Netherlands 🇳🇱
commented
Issue summary: View changes
eelkeblok’s picture

eelkeblok
he/him
Primary language Dutch
Location Netherlands 🇳🇱
commented
Issue summary: View changes
smustgrave’s picture

smustgrave commented

If it doesn’t break anything I’m all for it

prudloff made their first commit to this issue’s fork.

smustgrave’s picture

smustgrave commented
Version: 3.1.x-dev » 4.0.x-dev
Issue tags: -Drupal 11 compatibility

Lets do this in 4.0.x

smustgrave opened merge request !108

  • smustgrave committed e90b1938 on 4.0.x 
    task: #3484859 Move from state API tot dedicated key/value collection
smustgrave’s picture

smustgrave commented
Status: Active » Fixed

Done!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.