Problem/Motivation
Now that all of our basic gitlab automated tests pass we should not allow reintroduction of code that fails those tests.
Steps to reproduce
It is currently possible to merge code that fails the gitlab automated tests.
Proposed resolution
Add configuration to gitlab-ci.yml to stop allowing merging of code that fails automated tests.
cspell:
allow_failure: false
eslint:
allow_failure: false
phpcs:
allow_failure: false
phpstan:
allow_failure: false
Remaining tasks
1. Add merge request with updates to gitlab-ci.yml
User interface changes
N/A
API changes
N/A
Data model changes
N/A
Issue fork config_snapshot-3484430
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
trackleft2Comment #4
trackleft2Should be merged after #3484248: Address PHPCS error messages lands.
Comment #5
joegraduateLooks like we have new PHPCS failures
Comment #6
joegraduateNever mind. Just needed to update the MR with the latest changes from 2.0.x
Comment #7
joegraduateLGTM. Thanks @trackleft2!
Comment #9
joegraduateMerged.