Problem/Motivation

Now that all of our basic gitlab automated tests pass we should not allow reintroduction of code that fails those tests.

Steps to reproduce

It is currently possible to merge code that fails the gitlab automated tests.

Proposed resolution

Add configuration to gitlab-ci.yml to stop allowing merging of code that fails automated tests.

cspell:
  allow_failure: false
eslint:
  allow_failure: false
phpcs:
  allow_failure: false
phpstan:
  allow_failure: false

Remaining tasks

1. Add merge request with updates to gitlab-ci.yml

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

trackleft2 created an issue. See original summary.

trackleft2’s picture

Status: Active » Needs review
trackleft2’s picture

joegraduate’s picture

Status: Needs review » Postponed

Looks like we have new PHPCS failures

joegraduate’s picture

Status: Postponed » Needs review

Never mind. Just needed to update the MR with the latest changes from 2.0.x

joegraduate’s picture

Category: Plan » Task
Status: Needs review » Reviewed & tested by the community

LGTM. Thanks @trackleft2!

joegraduate’s picture

Assigned: trackleft2 » Unassigned
Status: Reviewed & tested by the community » Fixed

Merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.