Add the template .gitlab-ci.yml and see what the testing framework returns. Address the phpcs and phpstan issues at a minimum.

Issue fork bg_img_field-3484416

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

john franklin created an issue. See original summary.

  • c2d4042b committed on 8.x-1.x 
    Issue #3484416: Enable pipelines.

  • 5bb20a8a committed on 8.x-2.x 
    Issue #3484416: Enable pipelines.
arunsahijpal’s picture

arunsahijpal commented
Assigned: Unassigned » arunsahijpal

working on it.

john franklin’s picture

john franklin commented

I just merged @nicholass's patch in #3484950: Error: Call to a member function load() on null BgImgFieldFormatter, which cleans up some of the phpcs findings. Make sure you're using the latest 8.x-2.x.

arunsahijpal opened merge request !6

arunsahijpal’s picture

arunsahijpal commented
Assigned: arunsahijpal » Unassigned
Status: Active » Needs review

hi @john-franklin,
I've removed all the errors almost but there are some errors which are problematic, Please have a look.

  168    Parameter $token_service of method                                                  
         Drupal\bg_img_field\Plugin\Field\FieldFormatter\BgImgFieldFormatter::__construct()  
         has invalid type Drupal\token\TokenServiceInterface.                                
        189    Access to an undefined property                                                     
         Drupal\bg_img_field\Plugin\Field\FieldFormatter\BgImgFieldFormatter::$logger.                                                                           
            https://phpstan.org/blog/solving-phpstan-access-to-undefined-property            
        396    Access to an undefined property                                                     
         Drupal\bg_img_field\Plugin\Field\FieldFormatter\BgImgFieldFormatter::$logger.
john franklin’s picture

john franklin commented
Status: Needs review » Needs work

Shifting back to needs work to handle the merge conflict.

arunsahijpal opened merge request !7

arunsahijpal changed the visibility of the branch 3484416-enable-gitlab-pipelines to hidden.

arunsahijpal’s picture

arunsahijpal commented
Status: Needs work » Needs review

Hi @john-franklin,
I have moved all the to new branch 3484416-addressed-pipelines-issues
and the new MR is : MR 7

john franklin’s picture

john franklin commented
Status: Needs review » Fixed

Merged with latest 8.x-2.x, cleaned up the residuals, merged. Thanks for the patch, @arunsahijpal!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.