Problem/Motivation

Hook info doesn't properly pick up helpers from automatically included .inc anymore.

This does not cause an issue currently because the hooks themselves are in these includes and they got loaded as any other include would
However, once hooks are converted and only helpers remain , there's no mechanism left which would include these files.

Steps to reproduce

Try converting a hook_info.

Proposed resolution

hook_hook_info() is used to define include files which are automatically loaded by module handler. This got removed in #3442009: OOP hooks using attributes and event dispatcher and needs to be restored.

Remaining tasks

N/A

User interface changes

N/A

Introduced terminology

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

Issue fork drupal-3484105

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nicxvan created an issue. See original summary.

nicxvan opened merge request !9976

nicxvan’s picture

nicxvan commented
Title: Hook info must be procedural and module handler needs to handle hook_info properly » Hook info doesn't properly pick up helpers from .inc anymore
nicxvan’s picture

nicxvan commented
Title: Hook info doesn't properly pick up helpers from .inc anymore » Hook info must be procedural and module handler needs to handle hook_info properly
Issue summary: View changes
nicxvan’s picture

nicxvan commented
Title: Hook info must be procedural and module handler needs to handle hook_info properly » Automatically included .inc files are no longer included
nicxvan’s picture

nicxvan commented
Issue summary: View changes
Parent issue: » #3442009: OOP hooks using attributes and event dispatcher
nicxvan’s picture

nicxvan commented
Status: Active » Needs review
nicxvan’s picture

nicxvan commented
Issue summary: View changes
godotislate’s picture

godotislate
he/him
commented

Couple small comments.

godotislate’s picture

godotislate
he/him
commented
Status: Needs review » Needs work
nicxvan’s picture

nicxvan commented
Status: Needs work » Needs review
godotislate’s picture

godotislate
he/him
commented
Status: Needs review » Reviewed & tested by the community

lgtm

nicxvan’s picture

nicxvan commented

Test failure was unrelated, rerunning

  • catch committed 201c8394 on 11.x 
    Issue #3484105 by nicxvan, godotislate: Automatically included .inc...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.1.x, thanks!

  • catch committed 3b0d42bf on 11.1.x 
    Issue #3484105 by nicxvan, godotislate: Automatically included .inc...

catch closed merge request !9976

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.