Overview

Update the XB to use the latest Drupal 11 phpcs.xml.dist.

Proposed resolution

Match upstream changes:
Fix MissingParamType in core/lib/Drupal/Component

Use DrupalPractice.CodeAnalysis.VariableAnalysis for Kernel and Unit tests

User interface changes

None

Issue fork experience_builder-3484045

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

omkar-pd created an issue. See original summary.

omkar-pd opened merge request !375

omkar-pd’s picture

omkar-pd commented
Issue summary: View changes
omkar-pd’s picture

omkar-pd commented
Status: Active » Needs work

Need to fix Phpcs after updating core.phpcs.xml.dist

atul_ghate made their first commit to this issue’s fork.

atul_ghate’s picture

atul_ghate commented
Status: Needs work » Needs review
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me, thanks.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Component: Page builder » Code

RTBC++

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Bypassing the need for @traviscarden's approval, because the affected OpenAPI code is only getting cosmetic changes, no logical/semantical ones.

  • wim leers committed ef96f9ae on 0.x authored by omkar-pd 
    Issue #3484045 by omkar-pd, atul_ghate, longwave: Update XB to match the...
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.