Problem/Motivation

#3337643: Apply B5 accordion styles to HTML element details refactored details.html.twig and in doing so added a bg-light class to <details>. When a details element is used in a "dark" context, i.e. one which isn't "light", this introduces an unwanted light colour background which cannot easily be overridden due to bs's !important rule on .bg-light.

Steps to reproduce

Use a module like lb_claro which renders the side bar in a dark version, view a details element and note the text rendered on the light background is illegible.

Screenshot of the issue:

Proposed resolution

I can't see a reason for bg-light class given a details element might appear in context where the light version isn't correct. Lets try removing it.

Remaining tasks

Test

CommentFileSizeAuthor
bootstrap5-incorrect-bg-light-class.png10.44 KBfenstrat

Issue fork bootstrap5-3482619

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fenstrat created an issue. See original summary.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
Related issues: +#3380986: Layout builder block category label not visible with simple block module enabled

#3380986: Layout builder block category label not visible with simple block module enabled looks like the same issue, and it also looks like it wouldn't have been solved by #3337643: Apply B5 accordion styles to HTML element details.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
Status: Active » Needs review

MR !80 simply removes the 'bg-light' class.

fenstrat opened merge request !80

jannakha’s picture

jannakha commented
Status: Needs review » Reviewed & tested by the community

tested, all good - ready to merge

vladimiraus made their first commit to this issue’s fork.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Thank you all for your contributions. 🎂
Committed.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.