Problem/Motivation

Steps to reproduce

Install Market Wave theme and set as a default theme, Hover on home page slider. Right side arrow is in wrong position

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 After_arrows.png492.1 KBdishakatariya
#4 Before_arrows.png554.19 KBdishakatariya
#3 after_slider_arrow_direction_changed.png857.11 KBjaydeep_patel
Slider_arrow_wrong_position.png506.94 KBjaydeep_patel

Issue fork market_wave-3480091

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jaydeep_patel created an issue. See original summary.

jaydeep_patel opened merge request !9

jaydeep_patel’s picture

jaydeep_patel commented
Assigned: jaydeep_patel » Unassigned
Status: Active » Needs review
StatusFileSize
new after_slider_arrow_direction_changed.png857.11 KB

Slider position has been changed, Attached screen shot for the same.

dishakatariya’s picture

dishakatariya commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Before_arrows.png554.19 KB
new After_arrows.png492.1 KB

Slider arrows direction looks good now.
Hence moving it to RTBC
RTBC++

Anonymous’s picture

Anonymous (not verified) commented
Status: Reviewed & tested by the community » Needs work

Hi @jaydeep_patel

There seems to be a merge conflict in the MR which needs to be resolved. Can you please look into it and resolve the conflict?
Moving it back to NW for now

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Needs review

Resolved the Merge conflict
Moving it to NR
Can someone take a look?

jaydeep_patel’s picture

jaydeep_patel commented

Thanks for resolving conflict @akulsaxena,
It may be that the CSS was not generated, so I generated it and pushed it. Now arrow direction looks good, Please review it.

Thank you!!

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Reviewed & tested by the community

@jaydeep_patel
This looks good, the slider arrow's position is now correct
Moving it to RTBC

Anonymous’s picture

Anonymous (not verified) commented
Status: Reviewed & tested by the community » Needs work

@jaydeep_patel

Seems like some changes were merged on the source branch and this branch is a few commits behind the source branch.
Merge conflicts have come up again, please take a look.

yogesh.k made their first commit to this issue’s fork.

yogesh.k’s picture

yogesh.k commented
Version: 1.0.4 » 1.0.6
Status: Needs work » Fixed
yogesh.k’s picture

yogesh.k commented
Status: Fixed » Closed (fixed)