Closed (fixed)
Project:
Starshot Demo Design System
Version:
1.0.x-dev
Component:
Ideas
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
9 Oct 2024 at 20:14 UTC
Updated:
13 Mar 2025 at 01:11 UTC
Jump to comment: Most recent
Comments
Comment #2
carlitus commentedI don't know the components from CivicTheme but in Omitsis we use Mercury editor with this components:
Layout type:
Content type:
Comment #3
kristen polThanks so much!
I'm marking the ones that have CivicTheme components and bolded the ones that don't.
Layout type:
Content type:
Ignoring the naming differences, here are some thoughts on the ones we don't have OOTB. Note also that we have several kinds of cards which could be thought through further.
Comment #4
guptahemant commentedI think we did a small experiment with sliders before, we can continue on that. Also we should try tabs and accordions, Additionally trying out a unique field and widget like rating would be interesting to see how it behaves with XB.
Comment #5
kristen polThanks. The slider worked pretty well (wasn't demoed unfortunately). Agree about the tabs and accordions.
I am curious how we'd do some special field like a rating field... perhaps we can create our own schema? Not sure.
Comment #6
roromedia commentedHow fine-grained are the SDCs planned? Are you planning to add SDCs like "link", "button", "pill", "image", "video", etc. or other "smallish" components? Or do you think of SDCs rather as a combination of smaller partials as in a typical cards which incorporates "text", "button", "image" components?
Comment #7
kristen polWe already have atoms, molecules, and organisms that we are incorporating. These can be seen here in CivicTheme
https://uikit.civictheme.io/
Just curious what others are using regularly in their design systems, particularly at the molecule and organism level, that could be nice to have.
Comment #9
kristen polBeen discussing padding adjustments with Jacob. Let's decide if we'd want a "Spacer" type component to put in between components or if we want this type of padding to be handled per component.
Comment #10
shyam_bhatt@kristen pol, We can include the below components to the organisms:
Comment #11
carlitus commentedI think it's a lot better to have margins and paddings in the components instead of having a spacer component, a spacer has no semantic meaning.
+1 for #10
Comment #12
roromedia commentedI agree with
but these paddings or margins need to be configurable based on different breakpoints.
Comment #13
kristen polThanks for the feedback 🙏
Comment #14
carlitus commentedI think it is better to have this directly in all style properties.
For example, if you have margin-left you should be able to set, in addition to the default, a value for each breakpoint.
Comment #15
kristen polGotcha. One place where we allow different padding is for props+components that may want more or less breathing room above/below. But, I can see for the overall spacing defaults, perhaps having these globally defined so each site has some freedom to make things tighter or more airy.
Comment #16
roromedia commentedIt would make sense to me to integrate the existing breakpoints from the theme’s THEME.breakpoints.yml file. Additionally, it would be beneficial to centrally manage margin and padding styles in the XB configuration per breakpoint with classes. For example, if we use TailwindCSS breakpoints like sm, md, lg, xl, and 2xl in our breakpoints.yml file, we can set standard padding and margin values based on these breakpoints (eg. sm:p-1 md:p-1.5 lg:p-2 and so on - either directly or if there would be classes for that already we could map this in our CSS - this would be better because we wouldn't need to add those classes to our safelist because of purgeCSS). Component-specific overrides can then be handled within the XB settings of the respective component when needed.
Comment #17
kristen polThanks for the feedback 👍
Comment #18
kristen polLots of great stuff here and I want to make sure everyone gets credit for providing their thoughts.
Accordion definitely keeps coming up.
Video was blocked on XB the last time we looked at it:
#3479200: Integrate SDDS base theme video component with XB
If anyone is interested in working on any of these components, we can open specific issues for them. Let me know :)
Comment #19
kristen pol