Problem/Motivation

The "Composer (next major)" job just passed for the first time, thanks to rest_menu_items having a D11 compatible release.

But now, two tests are throwing a PluginNotFoundException: The "menu_link_content" entity type does not exist.

Also: all phpcs errors are quite recent, introduced by Gitlab's update to coder 8.3.25. Before, they were green. So we better just satisfy coder and make them green again -- so we're able to see new phpcs issues from the Job status.

Steps to reproduce

Check Gitlab job "phpunit (next version)" output. and phpcs.

Notes:

  • rest_menu_item's own tests are also currently failing. But I'm not sure that is related to the apparent missing menu item (config entity). (Probably not, because of the second point.)
  • our internal distro's pipeline is also failing to update to rest_menu_items 3.0.4 (while still on D10) -- it's because of the new allowed_menus config option, we need to enable the tested menu first.

Issue fork lupus_decoupled-3479682

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

roderik created an issue. See original summary.

roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Issue summary: View changes
Anonymous’s picture

Anonymous (not verified) commented

akulsaxena made their first commit to this issue’s fork.

Anonymous’s picture

Anonymous (not verified) commented
Assigned: Unassigned »

Working on it

roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Issue summary: View changes

rest_menu_items has a new allowed_menus config option, that is very likely the cause of it failing. The test needs to allow the appropriate menu first.

akulsaxena opened merge request !100

Anonymous’s picture

Anonymous (not verified) commented
Assigned: » Unassigned
Status: Active » Needs review

PHPCS (Coding standards) issues solved in 17 files.
PHPCS pipeline is now passing
All other pipelines now pass except for PHPUnit which gives the following error:

Uploading artifacts as "archive" to coordinator... 201 Created  id=3042729 responseStatus=201 Created token=glcbt-64
Uploading artifacts...
junit.xml: found 1 matching artifact files and directories 
WARNING: /builds/issue/lupus_decoupled-3479682/web/sites/default/files/simpletest/phpunit-*.xml: no matching files. Ensure that the artifact path is relative to the working directory (/builds/issue/lupus_decoupled-3479682) 
Uploading artifacts as "junit" to coordinator... 201 Created  id=3042729 responseStatus=201 Created token=glcbt-64
Cleaning up project directory and file based variables
ERROR: Job failed: command terminated with exit code 2

It says the phpunit-*.xml file is not found in the web folder (project root directory) and i dont have access to the root directory.

useernamee’s picture

useernamee commented

There's an issue with eslint. This change is required (from pipeline artifacts)

diff --git a/modules/lupus_decoupled_responsive_preview/js/lupus_decoupled_responsive_preview.js b/modules/lupus_decoupled_responsive_preview/js/lupus_decoupled_responsive_preview.js
index 78c8013..59a7619 100644
--- a/modules/lupus_decoupled_responsive_preview/js/lupus_decoupled_responsive_preview.js
+++ b/modules/lupus_decoupled_responsive_preview/js/lupus_decoupled_responsive_preview.js
@@ -38,7 +38,8 @@
         const $url = drupalSettings.responsive_preview.url;
         const $frontendBaseUrl = drupalSettings.lupus_decoupled_frontend_url;
         if ($frontendBaseUrl && $url.indexOf('://') < 0) {
-          $frame.get(0).contentWindow.location = `${$frontendBaseUrl} / ${$url}`;
+          $frame.get(0).contentWindow.location =
+            `${$frontendBaseUrl} / ${$url}`;
         } else {
           $frame.get(0).contentWindow.location = $url;
         }
Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Needs work
useernamee’s picture

useernamee commented
Assigned: Unassigned » roderik
Status: Needs work » Needs review

The pipeline is green. I'm not sure why, but LupusSessionDomainFunctionalTest was complaining about menu_link_content somehow.

This fix has to be moved to #3481050: Add tests for lupus_decoupled_user_forms as well.

  • roderik committed 5d718c27 on 1.x authored by akulsaxena 
    Issue #3479682 by useernamee, akulsaxena, roderik: Make Gitlab pipeline...
roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Status: Needs review » Fixed

Thank you. Reviewed, looks good, so merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.