Drupal Version

Drupal 10

Domain module version

2.0.x-dev as selected above.

Expected Behavior

[What did you try to do? What URL did you use to do it?]
I want to be able to select "is all of" in Views Exposed filter, to be able to filter content that belongs to both domains I am selecting, not "any of".

Actual Behavior

[What actually happened?]
"is all of" not available as an option for Domain but is for taxonomy.

Steps to reproduce

[A bullet list of steps to reproduce the error. Note if the error always happens or sometimes happens.]
- Edit the /admin/content view with the aim of extending the Exposed filter for domain to be able to add "is all of".
- Observed that this "is all of" option is not available.

Issue fork domain-3479341

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

therobyouknow created an issue. See original summary.

ctgraham’s picture

We are also interested in support for "is all of".

Class Drupal\domain_access\Plugin\views\filter\DomainAccessFilter could readily extend Drupal\views\Plugin\views\filter\ManyToOne rather than Drupal\views\Plugin\views\filter\InOperator, but existing filters would have settings where the operator value is "in" and "not in", rather than "or" and "not", respectively. The change will need to migrate the existing operator values, or will need to support legacy values.

mably’s picture

Status: Active » Needs work

Wouldn't it be better to migrate current InOperator to ManyToOne using an update hook?

mably’s picture

Status: Needs work » Needs review
Issue tags: +next-release
dhruv.mittal’s picture

Reviewing it

dhruv.mittal’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new400.86 KB

Able to see the "Is all of" button after applying the MR
So moving it to RTBC
Thanks

mably’s picture

Thanks a lot @dhruv.mittal for the review.

Have you been able to test the related update hook?

I would not want to break hundreds of sites because of a failing update.

  • mably committed 3bbaf702 on 2.0.x authored by ctgraham
    Issue #3479341 by therobyouknow, ctgraham, mably: Add "Is all of"...
mably’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: -next-release

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

  • mably committed 3a7e970f on 3.x authored by ctgraham
    Issue #3479341 by therobyouknow, ctgraham, mably: Add "Is all of"...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.