Problem/Motivation

gitlab jobs are failing on 11.0.x (core and contrib) due to > 250k files in artifacts from yarn install.

Numbers from @fjgarlin in slack:

11.0.x-dev ~ 286795 matching artifact files and directories
11.x-dev ~ 79881 matching artifact files and directories
10.3.6 ==> 64461 matching artifacts

My only guess is that some version of a dependency in 11.0.x has a dependency bomb, compared to both 10.3.x and 11.x branches.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3479160

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch credited fjgarlin.

catch credited nod_.

catch’s picture

catch
he/him
Primary language English
commented
fjgarlin’s picture

fjgarlin commented

something ckeditor5 related?? https://git.drupalcode.org/project/decoupled_pages/-/jobs/2979028

2284 web/core/node_modules/@ckeditor
that’s 2.2G for that folder alone

catch’s picture

catch
he/him
Primary language English
commented

It looks like we have a mis-matched version of ckeditor5-alignment in 11.0.x

11.x

    "@ckeditor/ckeditor5-alignment": "~43.1.1",
    "@ckeditor/ckeditor5-autoformat": "~43.1.1",
    "@ckeditor/ckeditor5-basic-styles": "~43.1.1",
    "@ckeditor/ckeditor5-block-quote": "~43.1.1",
    "@ckeditor/ckeditor5-code-block": "~43.1.1",
    "@ckeditor/ckeditor5-editor-classic": "~43.1.1",
    "@ckeditor/ckeditor5-editor-decoupled": "~43.1.1",
    "@ckeditor/ckeditor5-essentials": "~43.1.1",
    "@ckeditor/ckeditor5-heading": "~43.1.1",
    "@ckeditor/ckeditor5-horizontal-line": "~43.1.1",
    "@ckeditor/ckeditor5-html-support": "~43.1.1",
    "@ckeditor/ckeditor5-image": "~43.1.1",
    "@ckeditor/ckeditor5-indent": "~43.1.1",
    "@ckeditor/ckeditor5-language": "~43.1.1",
    "@ckeditor/ckeditor5-link": "~43.1.1",
    "@ckeditor/ckeditor5-list": "~43.1.1",
    "@ckeditor/ckeditor5-paste-from-office": "~43.1.1",
    "@ckeditor/ckeditor5-remove-format": "~43.1.1",
    "@ckeditor/ckeditor5-show-blocks": "~43.1.1",
    "@ckeditor/ckeditor5-source-editing": "~43.1.1",
    "@ckeditor/ckeditor5-special-characters": "~43.1.1",
    "@ckeditor/ckeditor5-style": "~43.1.1",
    "@ckeditor/ckeditor5-table": "~43.1.1",

11.0.x

    "@ckeditor/ckeditor5-alignment": "~42.0.2",
    "@ckeditor/ckeditor5-autoformat": "~43.1.1",
    "@ckeditor/ckeditor5-basic-styles": "~43.1.1",
    "@ckeditor/ckeditor5-block-quote": "~43.1.1",
    "@ckeditor/ckeditor5-code-block": "~43.1.1",
    "@ckeditor/ckeditor5-editor-classic": "~43.1.1",
    "@ckeditor/ckeditor5-editor-decoupled": "~43.1.1",
    "@ckeditor/ckeditor5-essentials": "~43.1.1",
    "@ckeditor/ckeditor5-heading": "~43.1.1",
    "@ckeditor/ckeditor5-horizontal-line": "~43.1.1",
    "@ckeditor/ckeditor5-html-support": "~43.1.1",
    "@ckeditor/ckeditor5-image": "~43.1.1",
    "@ckeditor/ckeditor5-indent": "~43.1.1",
    "@ckeditor/ckeditor5-language": "~43.1.1",
    "@ckeditor/ckeditor5-link": "~43.1.1",
    "@ckeditor/ckeditor5-list": "~43.1.1",
    "@ckeditor/ckeditor5-paste-from-office": "~43.1.1",
    "@ckeditor/ckeditor5-remove-format": "~43.1.1",
    "@ckeditor/ckeditor5-show-blocks": "~43.1.1",
    "@ckeditor/ckeditor5-source-editing": "~43.1.1",
    "@ckeditor/ckeditor5-special-characters": "~43.1.1",
    "@ckeditor/ckeditor5-style": "~43.1.1",
    "@ckeditor/ckeditor5-table": "~43.1.1",

https://www.drupal.org/project/drupal/issues/3477799

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Related issues: +#3477799: Update CKEditor 5 to 43.1.1

Yep seems like #3477799: Update CKEditor 5 to 43.1.1 is the culprit

$ cd core
$ rm -rf node_modules
$ yarn
$ du -sh node_modules
2.6G	node_modules/

$ git revert -n 7a8f123e95b15ab06f39296dd12328c38fbf9913 # CKEditor 5 v43.1.1
$ rm -rf node_modules
$ yarn
$ du -sh node_modules
319M	node_modules/

longwave opened merge request !9769

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review 
$ rm -rf node_modules
$ yarn
$ du -sh node_modules
328M	node_modules/
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Also added a unit test to ensure all CKEditor5 versions match in package.json. The test fails on 11.0.x:

1) Drupal\Tests\ckeditor5\Unit\VersionTest::testVersionAlignment
Failed asserting that actual size 2 matches expected size 1.
fjgarlin’s picture

fjgarlin commented
Status: Needs review » Reviewed & tested by the community

Thanks for the fix and the extra test. It all looks good.
RTBC.

catch closed merge request !9769

  • catch committed b53484ab on 10.3.x 
    Issue #3479160 by longwave, catch, fjgarlin, nod_: 11.0.x yarn...

  • catch committed 130507c4 on 10.4.x 
    Issue #3479160 by longwave, catch, fjgarlin, nod_: 11.0.x yarn...

  • catch committed 70c1b4f5 on 11.0.x 
    Issue #3479160 by longwave, catch, fjgarlin, nod_: 11.0.x yarn...

  • catch committed 85861056 on 11.x 
    Issue #3479160 by longwave, catch, fjgarlin, nod_: 11.0.x yarn...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.0.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed just the test to 11.x, 10.4.x and 10.3.x, and the test + fix to 11.0.x, thanks!

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Fixing credit

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.