As a first step to fixing the current test failures, we need to lock down typing in the aggregator functions and fix any problems that arise.

Issue fork views_aggregator-3478883

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tr created an issue. See original summary.

tr opened merge request !14

tr’s picture

tr commented

Well, that didn't break anything...but there are still some object hints that I want to convert to proper class/interface names, once I figure out what those should be.

  • tr committed 733ad541 on 2.1.x 
    Issue #3478883 by tr: Parameter typing and return type hints
tr’s picture

tr commented
Status: Active » Fixed

So apparently declare(strict_types=1); on the Table plugin causes a lot of problems, almost certainly because of the parent class (core Drupal Views module Table) doesn't use strict_types and has some typing problems.

I think there are already a lot of changes in this MR and I want to get this much in - none of these changes breaks anything, so it will make a good new baseline from which we can try to address the strict_types.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

gogowitsch’s picture

gogowitsch commented

The new type hints caused issue 3493815.