\Drupal\experience_builder\EventSubscriber\ApiResponseValidator::performXbValidation() seems to be effectively dead code in the absence of the x-xb-validation custom openapi.yml validation method being discussed in #3471064: OpenApi validation is not enforced because openapi.yml uses `patternProperties` which is not supported by our dependencies.
We should remove the dead code and let them decide how to handle the whole feature atomically in #3471064: OpenApi validation is not enforced because openapi.yml uses `patternProperties` which is not supported by our dependencies.
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
traviscarden commentedSince #3471064: OpenApi validation is not enforced because openapi.yml uses `patternProperties` which is not supported by our dependencies is yours, @tedbow, I'll ask you to approve this.
Comment #4
traviscarden commentedComment #5
tedbowyep, this find we can add it back exactly in the other issue if we need it
Comment #7
tedbowComment #8
wim leersThe removal of
x-xb-validationin/openapi.ymlseems to have been accidental in this commit: https://git.drupalcode.org/project/experience_builder/-/merge_requests/1... ? 🤔Comment #9
traviscarden commentedIs that a question, @wim leers? 🙂
Comment #10
wim leersYes … it's me asking for confirmation whether this piece of code was intentionally dead or just accidentally wounded 😇
Comment #11
traviscarden commented"Wounded." Haha. No, it was actually dead. As I understand @tedbow per a conversation we had outside this issue, it was removed on purpose and put back in by accident during a merge or rebase. Trust us, @wim leers : we don't make mistakes around here. At least not when we're correcting our mistakes. 😉
Comment #12
wim leers😄
What a lovely comment! 👏