On our version and also on the Simplytest.me site the login page on desktop is crunched over in to the left hand part of the page and the logo is floating above it, not to the left as expected.

This problem is also present on the Wishlist page which suggests it is affecting various 'admin' type screens

CommentFileSizeAuthor
#9 my-first-drupal-app.lndo_.site_user_1_wishlist_wajorubratike.png139.13 KBkaaarrrtik
#9 waveWishlist.png98.56 KBkaaarrrtik
#7 market-wave-wishlist.jpg95.76 KBpetednz
#5 market-wave.jpg96.56 KBpetednz
Untitled 36.png38.07 KBpetednz
Untitled 35.jpg29 KBpetednz

Issue fork market_wave-3478147

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

petednz created an issue. See original summary.

petednz’s picture

petednz commented

maybe related to https://www.drupal.org/project/market_wave/issues/3467610

kaaarrrtik’s picture

kaaarrrtik commented
Assigned: Unassigned » kaaarrrtik
kaaarrrtik’s picture

kaaarrrtik commented

@petednz please share your steps to reproduce bug.

petednz’s picture

petednz commented
StatusFileSize
new market-wave.jpg96.56 KB

Thanks for asking. Go to https://simplytest.me/

type in market_wave

accept option for 1.0.4

Launch sandbox https://master-ief9wxrve0qcjo7kti7or89pdez8jyth.tugboatqa.com/

Login (admin/admin)

Visit /user and see display is like screenshot

shot

petednz’s picture

petednz commented

sorry - above wasn't what i should have replicated. starting again

petednz’s picture

petednz commented
StatusFileSize
new market-wave-wishlist.jpg95.76 KB

the above replicates it enough to show what happens at a /user page

on our own test site, which has commerce on it, then when. a user visits Wishlist, because the get the Admin theme (on our site it is using Claro)

they see text

but comparing this theme to eg Vani, at the Wishlist page the user sees the Vani theme, not claro, and the logo is not oddly placed.

My main point is (and apologies for disjointed report) - when using your theme with Commerce, any shopper going to their Wishlist has a bad experience unless we change the Admin Theme to use your theme, which is not ideal either.

kaaarrrtik opened merge request !8

kaaarrrtik’s picture

kaaarrrtik commented
StatusFileSize
new waveWishlist.png98.56 KB
new my-first-drupal-app.lndo_.site_user_1_wishlist_wajorubratike.png139.13 KB

Please review I had styled Wishlist page.
FullPage view
Mobile View

kaaarrrtik’s picture

kaaarrrtik commented
Assigned: kaaarrrtik » Unassigned
Status: Active » Needs review
Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Reviewed & tested by the community

@kaaarrrtik

I replicated the issue and your patch works fine for me!
Great work
Moving it to RTBC

yogesh.k made their first commit to this issue’s fork.

yogesh.k’s picture

yogesh.k commented
Version: 1.0.4 » 1.0.5
Status: Reviewed & tested by the community » Fixed
yogesh.k’s picture

yogesh.k commented
Status: Fixed » Closed (fixed)